From owner-freebsd-fs@FreeBSD.ORG  Tue Mar 23 13:30:04 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6D0D91065670
	for <freebsd-fs@hub.freebsd.org>; Tue, 23 Mar 2010 13:30:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 419AB8FC19
	for <freebsd-fs@hub.freebsd.org>; Tue, 23 Mar 2010 13:30:04 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2NDU4W6021786
	for <freebsd-fs@freefall.freebsd.org>; Tue, 23 Mar 2010 13:30:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2NDU44o021783;
	Tue, 23 Mar 2010 13:30:04 GMT (envelope-from gnats)
Date: Tue, 23 Mar 2010 13:30:04 GMT
Message-Id: <201003231330.o2NDU44o021783@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
From: Rick Macklem <rmacklem@uoguelph.ca>
Cc: 
Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs 
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Rick Macklem <rmacklem@uoguelph.ca>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2010 13:30:04 -0000

The following reply was made to PR kern/144330; it has been noted by GNATS.

From: Rick Macklem <rmacklem@uoguelph.ca>
To: Daniel Braniss <danny@cs.huji.ac.il>
Cc: Mikolaj Golub <to.my.trociny@gmail.com>,
        Jeremy Chadwick <freebsd@jdc.parodius.com>, freebsd-fs@FreeBSD.org,
        Kai Kockro <kkockro@web.de>, bug-followup@FreeBSD.org,
        gerrit@pmp.uni-hannover.de
Subject: Re: kern/144330: [nfs] mbuf leakage in nfsd with zfs 
Date: Tue, 23 Mar 2010 09:34:39 -0400 (EDT)

 On Tue, 23 Mar 2010, Daniel Braniss wrote:
 
 >> I only have a FreeBSD client at this point, and it doesn't cause the
 >> leak for nfsv3,udp for me here.
 > my client is also FreeBSD 8.0, strange
 >
 
 I was already using the patch below when I tested and couldn't see it,
 so I guess it now appears that the patch works.
 
 >>
 >> Doug Rabson pointed out that there would be a leak for the "default:"
 >> case too, although didn't know if that would occur in practice.
 > it does! :-)
 >
 >>
 >> So, maybe you could test this variant of the patch (just in case that
 >> was the slow leak...):
 >> --- rpc/svc.c.sav	2010-03-21 18:46:20.000000000 -0400
 >> +++ rpc/svc.c	2010-03-22 19:00:17.000000000 -0400
 >> @@ -819,9 +819,11 @@
 >>   					free(r->rq_addr, M_SONAME);
 >>   					r->rq_addr = NULL;
 >>   				}
 >> +				m_freem(args);
 >>   				goto call_done;
 >>
 >>   			default:
 >> +				m_freem(args);
 >>   				goto call_done;
 >>   			}
 >>   		}
 > that plugged it!
 > see
 > 	ftp://ftp.cs.huji.ac.il/users/danny/freebsd/mbuf-leak/store-02+++.ps
 
 Good work with the testing. I'll get it committed and put it up on the
 nfs patches page I have under http://people.freebsd.org/~rmacklem
 
 > thanks to you for taking time off of your retirement :-)
 >
 I plan on doing quite a bit of FreeBSD/NFS stuff during it, rick