From owner-freebsd-mips@FreeBSD.ORG Wed Oct 5 18:21:46 2011 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07D491065673 for ; Wed, 5 Oct 2011 18:21:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 5E2E58FC16 for ; Wed, 5 Oct 2011 18:21:44 +0000 (UTC) Received: from alf.home (alf.kiev.zoral.com.ua [10.1.1.177]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p95ILecW080865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 5 Oct 2011 21:21:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from alf.home (kostik@localhost [127.0.0.1]) by alf.home (8.14.5/8.14.5) with ESMTP id p95ILdOr094615; Wed, 5 Oct 2011 21:21:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by alf.home (8.14.5/8.14.5/Submit) id p95ILdmV094614; Wed, 5 Oct 2011 21:21:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: alf.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 5 Oct 2011 21:21:39 +0300 From: Kostik Belousov To: "Jayachandran C." Message-ID: <20111005182139.GG1511@deviant.kiev.zoral.com.ua> References: <20111004211144.GW1511@deviant.kiev.zoral.com.ua> <20111004215218.GY1511@deviant.kiev.zoral.com.ua> <20111005144605.GC1511@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="86Kqgbv7jwc0ijsN" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: mips@freebsd.org Subject: Re: Mips syscall entry point X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2011 18:21:46 -0000 --86Kqgbv7jwc0ijsN Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 05, 2011 at 10:50:29PM +0530, Jayachandran C. wrote: > 2011/10/5 Kostik Belousov : > > On Wed, Oct 05, 2011 at 05:56:10PM +0530, Jayachandran C. wrote: > >> On Wed, Oct 5, 2011 at 5:05 PM, Jayachandran C. > >> wrote: > >> > On Wed, Oct 5, 2011 at 3:22 AM, Kostik Belousov wrote: > >> >> On Wed, Oct 05, 2011 at 12:11:44AM +0300, Kostik Belousov wrote: > >> >>> Hi, > >> >>> below is the patch, test-compiled for XLP64 only, which converts t= he > >> >>> only remaining architecture MIPS to the new syscall entry sequence. > >> >>> The advantage of the conversion is sharing most of the code with a= ll > >> >>> other architectures and avoiding duplication. Also, the implementa= tion > >> >>> automatically feels the missed features for the MIPS, see the BUGS > >> >> s/feels/fills/, sorry > >> >>> section in the ptrace(2). > >> >> For the same reason, capsicum shall not work on MIPS. > >> >> > >> >>> > >> >>> I am asking for you help to debug and test the patch. Please keep = me > >> >>> on Cc:, I am not on the list. > >> >>> > >> >>> Thank you. > >> >>> > >> >>> diff --git a/sys/mips/include/proc.h b/sys/mips/include/proc.h > >> >>> index 11a1f8e..4c0b0b6 100644 > >> [...] > >> > > >> > This gives me a crash when I test it on XLR (32bit compile). =9AThe > >> > crash does not look obvious - I am looking at it, hope to resolve th= is > >> > soon. > >> > >> Actually it is fairly obvious :) =9Athe elf*_machdep.c has to be updat= ed > >> for using the cpu_fetch_syscall_args. With that change it comes up on > >> 32 bit - will do a few more tests on 64 bit to see how that goes. > >> > >> The other minor issue I saw was the locr0 usage in trap(), in call to > >> trapdebug_enter, =9Ait is fine now since =9ATRAP_DEBUG is not defined. > > > > Thank you very much. Your fix is applied, and I tried to cover both > > locr0 and code usage. > > > > Will wait for your testing. >=20 > This works for me, tried on o32/n32/n64 on XLR. Thanks for fixing this up > . > JC. Thank you again. Should I consider this as an approval to commit the patch ? (I will make universe it before committing anyway). --86Kqgbv7jwc0ijsN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6MoDMACgkQC3+MBN1Mb4iF3gCggjZn+OQ3bEHziYRpA6hZXQn8 Bf0AniGhcuh/WqfsArBLoPxM7+vYWsJr =iEEW -----END PGP SIGNATURE----- --86Kqgbv7jwc0ijsN--