From owner-freebsd-pf@FreeBSD.ORG Thu Sep 16 04:07:44 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 674) id E4E5716A4CF; Thu, 16 Sep 2004 04:07:44 +0000 (GMT) Delivered-To: mlaier@vampire.homelinux.org Received: (qmail 28816 invoked by alias); 22 Jun 2004 19:53:33 -0000 Delivered-To: max@vampire.homelinux.org Received: (qmail 28813 invoked from network); 22 Jun 2004 19:53:32 -0000 Received: from moutng.kundenserver.de (212.227.126.176) by p548085b6.dip.t-dialin.net with SMTP; 22 Jun 2004 19:53:32 -0000 Received: from [212.227.126.212] (helo=mxng16.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcrKn-0008Pj-00 for max@vampire.homelinux.org; Tue, 22 Jun 2004 21:53:33 +0200 Received: from [206.53.239.180] (helo=turing.freelists.org) by mxng16.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcrKm-00046Z-00 for max@love2party.net; Tue, 22 Jun 2004 21:53:32 +0200 Received: from localhost (localhost [127.0.0.1])ESMTP id B4ADD72C612; Tue, 22 Jun 2004 14:32:04 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02687-43; Tue, 22 Jun 2004 14:32:04 -0500 (EST) Received: from turing (localhost [127.0.0.1])ESMTP id 259AB72C680; Tue, 22 Jun 2004 14:32:04 -0500 (EST) Received: with ECARTIS (v1.0.0; list pf4freebsd); Tue, 22 Jun 2004 14:31:48 -0500 (EST) X-Original-To: pf4freebsd@freelists.org Delivered-To: pf4freebsd@freelists.org Received: from localhost (localhost [127.0.0.1])ESMTP id 2B55A72C612 for ; Tue, 22 Jun 2004 14:31:48 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 02619-38 for ; Tue, 22 Jun 2004 14:31:47 -0500 (EST) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.188])ESMTP id 97A8772C5B5 for ; Tue, 22 Jun 2004 14:31:47 -0500 (EST) Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BcrKT-0001nD-00 for pf4freebsd@freelists.org; Tue, 22 Jun 2004 21:53:13 +0200 Received: from [84.128.133.182] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1BcrKT-0004qZ-00 for pf4freebsd@freelists.org; Tue, 22 Jun 2004 21:53:13 +0200 From: Max Laier To: pf4freebsd@freelists.org User-Agent: KMail/1.6.2 References: <40D760E5.7000903@nipsi.de> <200406222003.36024.max@love2party.net> <40D88B97.5090207@nipsi.de> In-Reply-To: <40D88B97.5090207@nipsi.de> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_G2I2Atge+kSVf+S"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406222150.30587.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:e28873fbe4dbe612ce62ab869898ff08 X-Virus-Scanned: by amavisd-new at freelists.org X-archive-position: 351 X-ecartis-version: Ecartis v1.0.0 Sender: pf4freebsd-bounce@freelists.org Errors-To: pf4freebsd-bounce@freelists.org X-original-sender: max@love2party.net Precedence: normal X-list: pf4freebsd X-Virus-Scanned: by amavisd-new at freelists.org X-Provags-Forward: max@love2party.net -> max@vampire.homelinux.org X-UID: 467 X-Length: 5461 X-Mailman-Approved-At: Thu, 16 Sep 2004 04:12:49 +0000 Subject: [pf4freebsd] Re: if_fxp.c.patch X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Reply-To: pf4freebsd@freelists.org List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Thu, 16 Sep 2004 04:07:45 -0000 X-Original-Date: Tue, 22 Jun 2004 21:50:23 +0200 X-List-Received-Date: Thu, 16 Sep 2004 04:07:45 -0000 --Boundary-02=_G2I2Atge+kSVf+S Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 22 June 2004 21:42, Dennis Berger wrote: > Max Laier wrote: > >On Tuesday 22 June 2004 10:59, Dennis Berger wrote: > ><...> > > > >>>Spoken too quick ... I am able to reprocure and have a dump now, thanks > >>>for the head up ... I'll inform you when I have a conclusion. Thanks. > > > >Okay ... good news - should be fixed now/was not lock related at all. Bad > > news - it was plain stupidity. I forgot to check whether IFQ_DRV_DEQUEUE > > was > > so a check around IFQ_DRV_DEQUEUE was needed, why is this check needed > by the way? > does IF_DEQUEUE check this normally? No ... IF_DEQUEUE would just "always" succeed. IFQ_DEQUEUE can fail even if= =20 not IFQ_IS_EMPTY (under rate limiting e.g.). Most drivers already do this=20 check (as w/ kernel threads one could remove a packet from the queue even w= /=20 the old macros) - so maybe this can be considered a bug in if_fxp.c (which= =20 will be fixed with the altq transformation.) > >really able to give us an mbuf. > > > >Please check out the new diff and test again. Thanks and sorry. > > I'll do that Thanks =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-02=_G2I2Atge+kSVf+S Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBA2I2GXyyEoT62BG0RAga5AJ93FK/20sadGRHCxOEJwDGgV/wvPQCeNsYV 4PkxBOPHnXvKlKMvtZ0zkM8= =pkx/ -----END PGP SIGNATURE----- --Boundary-02=_G2I2Atge+kSVf+S--