From owner-svn-src-head@FreeBSD.ORG Sat Sep 27 20:41:53 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F0815FFE; Sat, 27 Sep 2014 20:41:52 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7402AF6B; Sat, 27 Sep 2014 20:41:52 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id s8RKfo6T054422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 28 Sep 2014 00:41:50 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id s8RKfo30054421; Sun, 28 Sep 2014 00:41:50 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sun, 28 Sep 2014 00:41:50 +0400 From: Gleb Smirnoff To: "Alexander V. Chernikov" Subject: Re: svn commit: r272211 - head/sys/net Message-ID: <20140927204150.GS884@FreeBSD.org> References: <201409271357.s8RDvmTC072149@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201409271357.s8RDvmTC072149@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2014 20:41:53 -0000 On Sat, Sep 27, 2014 at 01:57:48PM +0000, Alexander V. Chernikov wrote: A> Author: melifaro A> Date: Sat Sep 27 13:57:48 2014 A> New Revision: 272211 A> URL: http://svnweb.freebsd.org/changeset/base/272211 A> A> Log: A> Use underlying ports counters to get lagg statistics instead of A> per-packet accounting. A> This introduce user-visible changes like aggregating error counters. A> A> Reviewed by: asomers (prev.version), glebius A> CR: D781 A> MFC after: 2 weeks A> Sponsored by: Yandex LLC Btw, lagg_transmit() still contains two ifp->if_oerrors++. Can you look at them? It seems to me that the second one would account an error already accounted by port interface. -- Totus tuus, Glebius.