From owner-cvs-all  Thu Jan 16 14:20:26 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2B52637B401; Thu, 16 Jan 2003 14:20:25 -0800 (PST)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 995C343EB2; Thu, 16 Jan 2003 14:20:24 -0800 (PST)
	(envelope-from sam@errno.com)
Received: from melange (melange.errno.com [66.127.85.82])
	(authenticated bits=0)
	by ebb.errno.com (8.12.5/8.12.1) with ESMTP id h0GMKNnN044191
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Thu, 16 Jan 2003 14:20:24 -0800 (PST)?g
	(envelope-from sam@errno.com)œ
X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange
Message-ID: <20e801c2bdad$770d56f0$5a557f42@errno.com>
From: "Sam Leffler" <sam@errno.com>
To: "Justin T. Gibbs" <gibbs@scsiguy.com>,
	"Nate Lawson" <nate@root.org>,
	"Hidetoshi Shimokawa" <simokawa@FreeBSD.org>
Cc: <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org>
References:  <Pine.BSF.4.21.0301161007080.46845-100000@root.org> <621240000.1042754436@aslan.btc.adaptec.com>
Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c         fwohcivar.h
Date: Thu, 16 Jan 2003 14:20:23 -0800
Organization: Errno Consulting
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.50.4807.1700
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> >>   Modified files:
> >>     sys/dev/firewire     firewire.c fwdev.c fwohci.c fwohcivar.h
> >>   Log:
> >>   Improve memory allocation.
> >>   - Don't use contigmalloc() and allocate page by page to avoid
> >>           allocation failure.
> >>   - allocate buffer by PAGE_SIZE.
> >
> > Some comments.
> >
> >> - contigfree((void *)(uintptr_t)sc->fc.sid_buf,
> >> - OHCI_SIDSIZE, M_DEVBUF);
> >> + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF);
>
> malloced buffers are not guaranteed to be accessable by a device.
> Use bus dma instead.
>

New drivers should use bus_dma.  I recently hit an issue like this with
jumbo mbufs not being handled by the bge driver because it doesn't use bus
dma.

    Sam


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message