From owner-freebsd-net  Thu Jan 25 14:20: 3 2001
Delivered-To: freebsd-net@freebsd.org
Received: from mail2.netcologne.de (mail2.netcologne.de [194.8.194.103])
	by hub.freebsd.org (Postfix) with ESMTP id 8E1DB37B400
	for <net@FreeBSD.ORG>; Thu, 25 Jan 2001 14:19:44 -0800 (PST)
Received: from husten.security.at12.de (dial-213-168-89-127.netcologne.de [213.168.89.127] (may be forged))
	by mail2.netcologne.de (8.9.3/8.9.3) with ESMTP id XAA06836;
	Thu, 25 Jan 2001 23:19:37 +0100 (MET)
Received: from localhost (localhost.security.at12.de [127.0.0.1])
	by husten.security.at12.de (8.11.1/8.11.1) with ESMTP id f0PMJQA20260;
	Thu, 25 Jan 2001 23:19:26 +0100 (CET)
	(envelope-from pherman@frenchfries.net)
Date: Thu, 25 Jan 2001 23:19:25 +0100 (CET)
From: Paul Herman <pherman@frenchfries.net>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: Jonathan Lemon <jlemon@flugsvamp.com>, <net@FreeBSD.ORG>
Subject: Re: I have delayed ACK problems
In-Reply-To: <200101251751.MAA83819@khavrinen.lcs.mit.edu>
Message-ID: <Pine.BSF.4.32.0101252250480.10921-100000@husten.security.at12.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Thu, 25 Jan 2001, Garrett Wollman wrote:

> <<On Thu, 25 Jan 2001 11:14:03 -0600 (CST), Jonathan Lemon <jlemon@flugsvamp.com> said:
>
> The important part was the
> 	if (callout_pending(tp->tt_delack)) {
> 		...
> 		tp->t_flags |= TF_ACKNOW;
> 	}
>
> bit.  This causes us to ack immediately where previously we would just
> delay an already-schedule delayed ack.

Yep, that does it.  Simple.  Elegant.  I see now why my (bloated
unintelligible) patch worked, it also didn't reset the timer when a
delayed ack might have already been pending.

OK, there are other parts of the code that do the same thing
(TCP_REASS, SYN was ACKed, et. al.) but if no one objects, I'll
send-pr the patch to be commited.

Thanks everybody!!
-Paul.



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message