Date: Mon, 31 Mar 2003 14:44:13 -0500 From: Jake Burkholder <jake@locore.ca> To: Nate Lawson <njl@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c Message-ID: <20030331194413.GA37842@locore.ca> In-Reply-To: <200303311729.h2VHTi9k095144@repoman.freebsd.org> References: <200303311729.h2VHTi9k095144@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Apparently, On Mon, Mar 31, 2003 at 09:29:44AM -0800,
Nate Lawson said words to the effect of;
> njl 2003/03/31 09:29:44 PST
>
> FreeBSD src repository
>
> Modified files:
> sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c
> if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c
> if_wb.c if_xl.c
> Log:
> Clean up locking and resource management for pci/if_*
>
Seems like the same broken KASSERT was cut and pasted into all of these:
Index: pci/if_rl.c
===================================================================
RCS file: /home/ncvs/src/sys/pci/if_rl.c,v
retrieving revision 1.91
diff -u -r1.91 if_rl.c
--- pci/if_rl.c 31 Mar 2003 17:29:43 -0000 1.91
+++ pci/if_rl.c 31 Mar 2003 19:18:54 -0000
@@ -1103,7 +1103,7 @@
struct ifnet *ifp;
sc = device_get_softc(dev);
- KASSERT(mtx_initialized(&sc->rl_mtx), "rl mutex not initialized");
+ KASSERT(mtx_initialized(&sc->rl_mtx), ("rl mutex not initialized"));
RL_LOCK(sc);
ifp = &sc->arpcom.ac_if;
Index: pci/if_xl.c
===================================================================
RCS file: /home/ncvs/src/sys/pci/if_xl.c,v
retrieving revision 1.135
diff -u -r1.135 if_xl.c
--- pci/if_xl.c 31 Mar 2003 17:29:43 -0000 1.135
+++ pci/if_xl.c 31 Mar 2003 19:19:34 -0000
@@ -1740,7 +1740,7 @@
int rid, res;
sc = device_get_softc(dev);
- KASSERT(mtx_initialized(&sc->xl_mtx), "xl mutex not initialized");
+ KASSERT(mtx_initialized(&sc->xl_mtx), ("xl mutex not initialized"));
XL_LOCK(sc);
ifp = &sc->arpcom.ac_if;
etc.
Jake
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030331194413.GA37842>