From owner-svn-src-all@FreeBSD.ORG Fri Nov 9 19:32:38 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 53BA36B8; Fri, 9 Nov 2012 19:32:38 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 627618FC0C; Fri, 9 Nov 2012 19:32:36 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id e12so4098174lag.13 for ; Fri, 09 Nov 2012 11:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=GtcudtqUtLkKh/Bd2hNEljaq6UTpU0EyCfqPPOudKGg=; b=pUW5hYov4UxuqFiS/uBV+KZxNcu74N25Nh+0r8jnApNeLwtRjT8y0ZPqUHrI83k1wS YRJaldlXlOqPhz+Zcmjq2HD57FYGJHyOiUqAuI17FbrKFJafaNgkgH71o1KRom6nQCSb LDs2Uil7hQrYUf3rIDuW1zSnUjJf+5LsYx6offAfVNyoUp7aEWPqKNJqaAAx+aYLT/m5 Et1MlObhDZr5LkOcIntkKtKj87stxTymIAmylrHFO8IgEcgI+hgfN5tvrsb2+FXxPgB+ Upmq4Af46+e8GiXypMKHnz+594YWnnLptwSSZBrC9e1U05Sp2TGXgsKBQ3zHXFUr46jB w+Hw== MIME-Version: 1.0 Received: by 10.152.104.50 with SMTP id gb18mr11736256lab.9.1352489555954; Fri, 09 Nov 2012 11:32:35 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.112.30.37 with HTTP; Fri, 9 Nov 2012 11:32:35 -0800 (PST) In-Reply-To: <20121109192254.GH73505@kib.kiev.ua> References: <201211091802.qA9I2QP6026142@svn.freebsd.org> <20121109181103.GF73505@kib.kiev.ua> <20121109192254.GH73505@kib.kiev.ua> Date: Fri, 9 Nov 2012 19:32:35 +0000 X-Google-Sender-Auth: 06q56xYbX_EaOKiBoknJrIfC9x8 Message-ID: Subject: Re: svn commit: r242833 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/devfs fs/ext2fs fs/fdescfs fs/fuse fs/msdosfs fs/nandfs fs/nfsclient fs/nullfs fs/pseudofs fs/tmpfs fs/udf... From: Attilio Rao To: Konstantin Belousov Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2012 19:32:38 -0000 On 11/9/12, Konstantin Belousov wrote: > On Fri, Nov 09, 2012 at 06:50:52PM +0000, Attilio Rao wrote: >> On Fri, Nov 9, 2012 at 6:47 PM, Attilio Rao wrote: >> > On Fri, Nov 9, 2012 at 6:11 PM, Konstantin Belousov >> > wrote: >> >> On Fri, Nov 09, 2012 at 06:02:26PM +0000, Attilio Rao wrote: >> >>> Author: attilio >> >>> Date: Fri Nov 9 18:02:25 2012 >> >>> New Revision: 242833 >> >>> URL: http://svnweb.freebsd.org/changeset/base/242833 >> >>> >> >>> Log: >> >>> Complete MPSAFE VFS interface and remove MNTK_MPSAFE flag. >> >>> Porters should refer to __FreeBSD_version 1000021 for this change >> >>> as >> >>> it may have happened at the same timeframe. >> >>> >> >>> Modified: head/sys/fs/fuse/fuse_vfsops.c >> >>> ============================================================================== >> >>> --- head/sys/fs/fuse/fuse_vfsops.c Fri Nov 9 17:56:49 2012 >> >>> (r242832) >> >>> +++ head/sys/fs/fuse/fuse_vfsops.c Fri Nov 9 18:02:25 2012 >> >>> (r242833) >> >>> @@ -339,7 +339,6 @@ fuse_vfsop_mount(struct mount *mp) >> >>> >> >>> vfs_getnewfsid(mp); >> >>> mp->mnt_flag |= MNT_LOCAL; >> >>> - mp->mnt_kern_flag |= MNTK_MPSAFE; >> >>> if (subtype) { >> >>> strlcat(mp->mnt_stat.f_fstypename, ".", MFSNAMELEN); >> >>> strlcat(mp->mnt_stat.f_fstypename, subtype, >> >>> MFSNAMELEN); >> >> >> >> mnt_flag update should happen under the mount interlock. >> > >> > Yes I already have a patch for that, I'm waiting for testing by flo. >> >> http://www.freebsd.org/~attilio/fuse_mnt_flag.patch > > Why mp->mnt_data and mp->mnt_stat.f_iosize updates are synchronized ? > VFS does not modify them. mnt_data is used within FUSE in a twisted way and MNT_ILOCK is just convenient for it. I need to recheck mnt_stat.f_iosize. Attilio -- Peace can only be achieved by understanding - A. Einstein