From owner-freebsd-current@FreeBSD.ORG Wed Aug 8 11:31:51 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 22951106566C for ; Wed, 8 Aug 2012 11:31:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 7468A8FC16 for ; Wed, 8 Aug 2012 11:31:49 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q78BVktE030601; Wed, 8 Aug 2012 14:31:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q78BVXBN043673; Wed, 8 Aug 2012 14:31:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q78BVXIK043672; Wed, 8 Aug 2012 14:31:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 8 Aug 2012 14:31:33 +0300 From: Konstantin Belousov To: Hans Petter Selasky Message-ID: <20120808113133.GO2676@deviant.kiev.zoral.com.ua> References: <20120801160323.GN2676@deviant.kiev.zoral.com.ua> <201208051033.13486.hselasky@c2i.net> <201208071703.13773.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="55kmsllhnyURxeAZ" Content-Disposition: inline In-Reply-To: <201208071703.13773.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Ed Schouten , freebsd-current@freebsd.org Subject: Re: ttydev_cdevsw has no d_purge X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2012 11:31:51 -0000 --55kmsllhnyURxeAZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 07, 2012 at 05:03:13PM +0200, Hans Petter Selasky wrote: > On Sunday 05 August 2012 10:33:13 Hans Petter Selasky wrote: > > On Friday 03 August 2012 10:32:47 Ed Schouten wrote: > > > 2012/8/1 Hans Petter Selasky : > > > > I think the problem is like this, that in order to re-use the unit > > > > numbers for USB serial tty devices, the USB stack needs to wait unt= il a > > > > TTY is actually freed, right? Else you will have a panic on creating > > > > devfs entries having the same name. > > >=20 > > > Indeed. So the USB code could simply pick a different unit number. > >=20 > > Hi Ed, > >=20 > > USB could use a different Unit number. Some questions: > >=20 > > When can the previous unit number be re-used? Is there a callback for t= his? > >=20 > > When can the USB serial code assume that it will not be called again and > > that all callbacks are drained? > >=20 >=20 > Hi, >=20 > Can you try the attached patch and report back? I applied the patch and reloaded ucom and uplcom. So far there were no power glitches so UPS did not dropped off the bus yet. I have a question regarding the changed fragment of code. Why don't you use unr(9) KPI to manage unit numbers ? --55kmsllhnyURxeAZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAlAiThUACgkQC3+MBN1Mb4jmVQCfYHZOywd1x0Iaq0d7LckIXVKk yvAAnilWFigHaDUOzbkm4+bpr9Zj4QTl =wEwM -----END PGP SIGNATURE----- --55kmsllhnyURxeAZ--