From owner-freebsd-current@freebsd.org Sun Nov 24 23:14:12 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BDB741BF67A for ; Sun, 24 Nov 2019 23:14:12 +0000 (UTC) (envelope-from yasu@utahime.org) Received: from gate.utahime.jp (gate.utahime.jp [183.180.29.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47LmFb3Pf0z4cqH for ; Sun, 24 Nov 2019 23:14:11 +0000 (UTC) (envelope-from yasu@utahime.org) Received: from eastasia.home.utahime.org (eastasia.home.utahime.org [192.168.174.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by gate.utahime.jp (Postfix) with ESMTPS id 7D9BD1D4C9 for ; Mon, 25 Nov 2019 08:14:01 +0900 (JST) Received: from localhost (rolling.home.utahime.org [192.168.174.11]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by eastasia.home.utahime.org (Postfix) with ESMTPSA id 09DE840C81; Mon, 25 Nov 2019 08:14:01 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.1 at eastasia.home.utahime.org Date: Mon, 25 Nov 2019 08:13:19 +0900 (JST) Message-Id: <20191125.081319.1547651065831056208.yasu@utahime.org> To: freebsd-current@freebsd.org Subject: Re: /etc/os-release isn't created From: Yasuhiro KIMURA In-Reply-To: References: <20191124.061357.2264854536159910571.yasu@utahime.org> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47LmFb3Pf0z4cqH X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of yasu@utahime.org designates 183.180.29.210 as permitted sender) smtp.mailfrom=yasu@utahime.org X-Spamd-Result: default: False [0.82 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.25)[-0.253,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a:spf-authorized.utahime.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.51)[-0.506,0]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[utahime.org]; MV_CASE(0.50)[]; MID_CONTAINS_FROM(1.00)[]; IP_SCORE(0.38)[ip: (0.28), ipnet: 183.180.0.0/16(0.14), asn: 2519(1.45), country: JP(0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:2519, ipnet:183.180.0.0/16, country:JP]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Nov 2019 23:14:12 -0000 From: Conrad Meyer Subject: Re: /etc/os-release isn't created Date: Sun, 24 Nov 2019 12:51:03 -0800 > Did you run etcupdate or mergemaster as part of updating your host? Yes. I run 'mergemaster -Fi' after 'make installworld' I recieved report by private mail that /etc/os-release is created only when 'make distribution' is executed. And I found that's exactly what is written in /usr/src/etc/Makefile. yasu@rolling-vm-freebsd1[2103]% grep '\$FreeBSD' /usr/src/etc/Makefile # $FreeBSD: head/etc/Makefile 354922 2019-11-20 23:45:31Z imp $ yasu@rolling-vm-freebsd1[2104]% tail +50 /usr/src/etc/Makefile | head -n 12 distribution: .if !defined(DESTDIR) @echo "set DESTDIR before running \"make ${.TARGET}\"" @false .endif ${_+_}cd ${.CURDIR}/gss; ${MAKE} install ${_+_}cd ${.CURDIR}/mtree; ${MAKE} install ${_+_}cd ${SRCTOP}/share/termcap; ${MAKE} etc-termcap ${_+_}cd ${SRCTOP}/usr.sbin/rmt; ${MAKE} etc-rmt ${INSTALL_SYMLINK} ../var/run/os-release \ ${DESTDIR}/etc/os-release yasu@rolling-vm-freebsd1[2105]% But 'make distribution' isn't executed by normal upgrade steps. So it's a bug and should be fixed. --- Yasuhiro KIMURA