From owner-cvs-all@FreeBSD.ORG Thu Jun 14 07:01:31 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0CBE016A46B; Thu, 14 Jun 2007 07:01:31 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail16.syd.optusnet.com.au (mail16.syd.optusnet.com.au [211.29.132.197]) by mx1.freebsd.org (Postfix) with ESMTP id 833F913C44B; Thu, 14 Jun 2007 07:01:30 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c220-239-235-248.carlnfd3.nsw.optusnet.com.au [220.239.235.248]) by mail16.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id l5E71Qb0028699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jun 2007 17:01:28 +1000 Date: Thu, 14 Jun 2007 17:01:26 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Xin LI In-Reply-To: <200706140316.l5E3GIMS013585@repoman.freebsd.org> Message-ID: <20070614170027.U31675@besplex.bde.org> References: <200706140316.l5E3GIMS013585@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mknod mknod.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2007 07:01:31 -0000 On Thu, 14 Jun 2007, Xin LI wrote: > delphij 2007-06-14 03:16:16 UTC > > FreeBSD src repository > > Modified files: > sbin/mknod mknod.c > Log: > In the previous changeset a cast of myminor to u_int were > removed, which will cause problems on architectures where > longs are longer than ints, for instance, > "mknod foo c 0 0xffff00ff" > would fail in such cases. > > Use a proper cast instead. > > Prompted by: bde Thanks. Er, it still has a wrong cast for the major number. Bruce