From owner-freebsd-net@FreeBSD.ORG Fri Apr 2 17:29:32 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id CBD01106566C
for <freebsd-net@freebsd.org>; Fri, 2 Apr 2010 17:29:32 +0000 (UTC)
(envelope-from ermal.luci@gmail.com)
Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54])
by mx1.freebsd.org (Postfix) with ESMTP id 6121E8FC0A
for <freebsd-net@freebsd.org>; Fri, 2 Apr 2010 17:29:32 +0000 (UTC)
Received: by wwb24 with SMTP id 24so1501329wwb.13
for <freebsd-net@freebsd.org>; Fri, 02 Apr 2010 10:29:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
h=domainkey-signature:mime-version:received:in-reply-to:references
:from:date:received:message-id:subject:to:cc:content-type
:content-transfer-encoding;
bh=RnfEnUFeabyFHBKJfXiguvUs1ixETBYKRlLupDZKfQE=;
b=ZjwfgO5aFObosbFXYChiUWxGw3vrB4zQ+btn0E8VSSR6S5mH003HYFPyjh1fWlKq7s
QYxlZnpWOjuVo1Vt3BmFc5TPWy901tKqWZCF618iJkaH855GguD6UsEyNOltAhD15Zlq
hj+t1upB9GJJcDg9P/opqXBeQP3Ubj3qvRrGw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to
:cc:content-type:content-transfer-encoding;
b=qZq3tEJ4mzmPuoU952oiYO+kqGj/K8ZkqTqQKLiY31fOYkZ00iJGiOlcBvJzTRBPX+
1Mp9npUJCRbF24LqO722BeZ3IkjWinpa3id5mLWAVARQJNQnsyIaurNUFbLrgJ95uicA
oOl+t3i6IuWwfMmVgCIPlttP++Gx66ckQ1Bls=
MIME-Version: 1.0
Received: by 10.216.73.199 with HTTP; Fri, 2 Apr 2010 10:29:11 -0700 (PDT)
In-Reply-To: <20100402170740.N40281@maildrop.int.zabbadoz.net>
References: <9a542da31003190453s1e7598efr8f35f525871f5589@mail.gmail.com>
<20100402170740.N40281@maildrop.int.zabbadoz.net>
From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <ermal.luci@gmail.com>
Date: Fri, 2 Apr 2010 19:29:11 +0200
Received: by 10.216.87.67 with SMTP id x45mr1439417wee.18.1270229371341; Fri,
02 Apr 2010 10:29:31 -0700 (PDT)
Message-ID: <s2j9a542da31004021029u531d4955u9fa1a1f892e0e63f@mail.gmail.com>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-net <freebsd-net@freebsd.org>
Subject: Re: Is this correct?
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2010 17:29:32 -0000
On Fri, Apr 2, 2010 at 7:11 PM, Bjoern A. Zeeb
<bzeeb-lists@lists.zabbadoz.net> wrote:
> On Fri, 19 Mar 2010, Ermal Lu=E7i wrote:
>
> Hi,
>
>> Shouldn't this check be
>> if (m->m_len > sizeof (struct ip)) {
>> instead of
>> if (m->m_len < sizeof (struct ip)) {
>
> Should it be > or >=3D ?
>
I would say >=3D since that is what logic assumes!
> /bz
>
> --
> Bjoern A. Zeeb =A0 =A0 =A0 =A0 It will not break if you know what you are=
doing.
--=20
Ermal