From owner-freebsd-current@FreeBSD.ORG Thu Jan 15 12:44:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D8B816A4CE for ; Thu, 15 Jan 2004 12:44:32 -0800 (PST) Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51E9C43D69 for ; Thu, 15 Jan 2004 12:44:18 -0800 (PST) (envelope-from andre@freebsd.org) Received: (qmail 75629 invoked from network); 15 Jan 2004 20:44:17 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.54]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 15 Jan 2004 20:44:17 -0000 Message-ID: <4006FBA0.F2057876@freebsd.org> Date: Thu, 15 Jan 2004 21:44:16 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: David Gilbert References: <40055744.5030607@freebsd.org> <16390.61995.829098.247043@canoe.dclg.ca> <16390.63251.901089.277458@canoe.dclg.ca> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: freebsd-net@freebsd.org cc: freebsd-current@freebsd.org Subject: Re: kern/61215: off-by-one error likely in ip_fragment() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2004 20:44:32 -0000 David Gilbert wrote: > > >>>>> "Andre" == Andre Oppermann writes: > > >> I'm not sure what's up. Your patch wouldn't apply to v1.17 of my > >> if_gre.c, so something's wrong with the patch. Regardless, I > >> applied the patch by hand and things didn't work yet. > > Andre> Didn't it apply because of patch complaining or because it > Andre> didn't match at all? > > It looked like it was mostly whitespace errors or somesuch. The patch > algorythm couldn't find the are to patch. > > ... however, as I said... I was able to patch it by hand. Ok. > >> The kernel didn't crash, but packets routed into the tunnel didn't > >> show up on the outbound interface. I my case, the machine has > >> three ethernet-like interfaces and the gre. > >> > >> wi0 and sis0 are internal networks. dc0 is the external network > >> interface. A /32 route for the far end of the tunnel exists (and > >> works on the new kernel ... it pings), but pings into the tunnel > >> don't generate traffic on dc0 (at least according to tcpdump). > > Andre> Do you enable "link1" on your GRE interface? > > What does link1 do to gre? It hasn't been necessary before. > > Andre> What does ifconfig -a show? > > Ifconfig -a output was normal. I didn't save the new output, but the > old output is the same ... save the fact that the new output prints > the tunnel endpoints. > > gre0: flags=9011 mtu 1476 > inet6 fe80::2d0:9ff:fee4:bbc2%gre0 prefixlen 64 scopeid 0x5 > inet 66.246.133.114 --> 66.246.133.113 netmask 0xfffffffc Where are the outer addresses? It should look like this (at least I was able to get correct packets out of it this way): gre0: flags=b051 mtu 1476 tunnel inet 62.48.0.50 --> 62.48.0.47 inet 192.168.1.1 --> 192.168.1.2 netmask 0xffffff00 I get to this by configuring the following: ifconfig gre0 create # create gre0 interface ifconfig gre0 tunnel 62.48.0.50 62.48.0.47 # outer addresses ifconfig gre0 192.168.1.1 192.168.1.2 # inner addresses ifconfig gre0 link1 # chose nexthop computation method ifconfig gre0 up # enable gre tunnel -- Andre