Date: Fri, 14 Sep 2012 00:07:24 -0700 (PDT) From: Michael Haro <mharo@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/171632: DVD option not defined for multimedia/vlc Message-ID: <201209140707.q8E77Owb066562@cake.bitsurf.net> Resent-Message-ID: <201209140710.q8E7AJZa037385@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 171632
>Category: ports
>Synopsis: DVD option not defined for multimedia/vlc
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 14 07:10:19 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Michael Haro
>Release: FreeBSD 9.1-RC1 amd64
>Organization:
>Environment:
System: FreeBSD cake.bitsurf.net 9.1-RC1 FreeBSD 9.1-RC1 #0: Tue Aug 14 04:25:06 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
OptionsNG only allows you to specify options that are listed in
OPTIONS_DEFINE. The Makefile for this port takes action based on if
the DVD option is set or not set, but doesn't provide you an
opportunity to set it since it isn't in the OPTIONS_DEFINE list.
>How-To-Repeat:
make rmconfig
env WITH_DVD=yes make config
see if A52, DVDREAD, DVDNAV options are checked
>Fix:
I'm not sure that this is the correct fix since if you select DVD it
doesn't enable DVDREAD when you do make showconfig, but it does enable
it if you put WITH_DVD in the environment. Hopefully you'll know the
correct fix.
--- Makefile.orig 2012-09-13 23:24:16.030282135 -0700
+++ Makefile 2012-09-13 23:52:10.445284340 -0700
@@ -25,7 +25,7 @@
BUILD_DEPENDS= ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
RUN_DEPENDS= ffmpeg${FFMPEG_SUFFIX}>0.11:${PORTSDIR}/multimedia/ffmpeg${FFMPEG_SUFFIX}
-OPTIONS_DEFINE= A52 AALIB ASS AVAHI CACA DBUS DIRAC DOCS DTS DVDREAD \
+OPTIONS_DEFINE= A52 AALIB ASS AVAHI CACA DBUS DIRAC DOCS DTS DVD DVDREAD \
DVDNAV FAAD FLAC FLUID FRIBIDI GLX GNOMEVFS GNUTLS GOOM \
HTTPD JACK LIVEMEDIA LUA MAD MATROSKA MODPLUG MPEG2 MTP \
MUSEPACK NCURSES NLS NOTIFY OPTIMIZED_CFLAGS OGG \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209140707.q8E77Owb066562>