From owner-svn-ports-head@freebsd.org Tue Mar 12 16:42:55 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3646B15360D1; Tue, 12 Mar 2019 16:42:55 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CA202703E4; Tue, 12 Mar 2019 16:42:54 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8BF151FC8D; Tue, 12 Mar 2019 16:42:54 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 0E6C09433BA; Tue, 12 Mar 2019 16:42:53 +0000 (UTC) Date: Tue, 12 Mar 2019 17:42:52 +0100 From: Mathieu Arnold To: Koichiro Iwao Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495325 - in head: . converters converters/pdf2djvu converters/pdf2djvu/files Message-ID: <20190312164252.gy24ciagttvxnnmw@ogg.in.absolight.net> References: <201903110232.x2B2W4aP026085@repo.freebsd.org> <20190312142649.mcouvbxfjawaozou@ogg.in.absolight.net> <20190312143934.fansco76gw5j5t2f@icepick.vmeta.jp> <20190312144438.qiuzovf7zclpn5pa@ogg.in.absolight.net> <20190312155505.qg37ghznbwqoo6vk@icepick.vmeta.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ezdqe7kxo4ur6doh" Content-Disposition: inline In-Reply-To: <20190312155505.qg37ghznbwqoo6vk@icepick.vmeta.jp> User-Agent: NeoMutt/20180622 X-Rspamd-Queue-Id: CA202703E4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 16:42:55 -0000 --ezdqe7kxo4ur6doh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2019 at 12:55:05AM +0900, Koichiro Iwao wrote: > On Tue, Mar 12, 2019 at 03:44:38PM +0100, Mathieu Arnold wrote: > > On Tue, Mar 12, 2019 at 11:39:34PM +0900, Koichiro Iwao wrote: > > > On Tue, Mar 12, 2019 at 03:26:49PM +0100, Mathieu Arnold wrote: > > > > On Mon, Mar 11, 2019 at 02:32:04AM +0000, Koichiro Iwao wrote: > > > > > +USE_GITHUB=3D yes > > > > > +GH_TUPLE=3D jwilk:${PORTNAME}:${PORTVERSION} > > > >=20 > > > > GH_ACCOUNT=3D jwilk > > >=20 > > > Yes, but what? > > >=20 > > > $ make -C /usr/ports/converters/pdf2djvu -VGH_ACCOUNT > > > jwilk > >=20 > > I was merely pointing out that what you wrote was bad and the correct > > way to express what you had meant. >=20 > You like beating around the bush. Well, there is a simple, and correct, way to do what you want to do, it is to set: GH_ACCOUNT=3D jwilk And there is the complicated way you used. The way you used will make other people looking at the Makefile wonder why you did it that way, if there was a reason to set GH_TUPLE to a complex value instead of siply GH_ACCOUNT, like some strange bug that you wanted to get around but forgot to mention in the commit message. If you do not with to get post-commit review of your changes so that we all get a simpler and easier to deal with ports tree, please say so. --=20 Mathieu Arnold --ezdqe7kxo4ur6doh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlyH4YxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjxig/6AntuIZAncT4gZ5xy4WpPgMh3/pNR4y96TdRWc3riLiZD3khO40T3Tmer dE4U9RuRfE2iVMSYDC8svKjghFCfQBTFnBegjPw0aweXjyGD3y0sF9/2Fk+lUTDx PwnINqLJyGks3NF1lUU66AiebpvgL6cwe5yMe6UQ2Gq9BBh9ogZEcw/l79IlcbWE T210yNJOdmKMVMvdwPt5u9THOheEXyAJs72nw9vpTosBoUmdWvcf+y1LHhD7HzNq yTniMfU2bXQ9Ybwo/6jeKIQC4M/1DiAA2ynL6UiyiG1mP1bBTZAU08k2z+4GEsN3 JcjiYtnN/W1dwLow6BcWpXKns83D8Fvow/1llGjCRZMrfXvSHIUQDjh8zKgKd055 4+t/jR4GtHCIEYIB1O3uqZw/JxyaK7B/pyc+u6Cao3Qy5VYI6yA/gmU3mNClP+Ml a8huMfoVSsw2p/N4k4UAxD2ytAz1ESTlvkOMgUFY9v7jCBdwFSExA8UUag6QeGH6 Eps+oEwgvW5aE1wiW/dwj+KVdSIGr/hxxVuOao41EVNfAiWe5CYn2m6oOjgdJIwB 6yCflGoGOkczzHUHMh9yB+hGlX6XRjwB65eNwOfCDrx8pVSs4m8VLGzEQYQdGrPj zNk/6qYyK6m/qg70DQNSVwvAZIfABLEIw46AXhpugV2yyy3xjak= =XQkF -----END PGP SIGNATURE----- --ezdqe7kxo4ur6doh--