From owner-svn-src-all@freebsd.org Wed Mar 14 12:44:50 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37C87F4FA1C; Wed, 14 Mar 2018 12:44:50 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B0E657EDF8; Wed, 14 Mar 2018 12:44:49 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf0-f44.google.com with SMTP id e5-v6so546914lfb.7; Wed, 14 Mar 2018 05:44:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GoU7R3s4zH3CS6xLNxpUzZ772/EB1SYCeHiqVpgEUd8=; b=I5nmqAFstrL5iURN03T9Av+j7/C5WXTqBjivlhFuanDoCd5nUgQxKsfaeQ8nI9/sPj XcJwJo1R3qkVBv1vkrcOXAfC6WkS5AOB6MitcrMHjCrcYsoDNfNd5uRt5hnJ2i2DMoyy G95q4ROOmlyi+a8iLG4Dvuu3IFS0BMePdx7JohGHLOkaVYWMPB0HVQJoTZA0fWdcROXp BdPSxMyco/le7XEb8ja+A/9Oq5bDFN3oNUQoQqmMlgag5Ysu0T0RSYSTfwE5k7Gydxir qcSqKiQJOTMA0vLPODmxmUl3fN4o0FKbT/h2EJZi2n2zs7xGiq4V0mn5LCBR0dzw3JdE QEwA== X-Gm-Message-State: AElRT7EGDj9Uon1UPDOneTnX0R7mxf2x2aEohxbfzqEFlBZIIlDLX6Dc OdMAorpmxbK348NP38D1myIwJb9i X-Google-Smtp-Source: AG47ELvYG6QDZQp6hJ3yCQ3d9yxPyMdUC0UOmyvZQvaNS/oFCzpGvJ9OxjWV9qqLMxTErp3Cdo5z7Q== X-Received: by 10.46.22.89 with SMTP id 25mr3329757ljw.86.1521031479859; Wed, 14 Mar 2018 05:44:39 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id f16sm572532lja.48.2018.03.14.05.44.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 05:44:38 -0700 (PDT) Subject: Re: svn commit: r330883 - head/stand/userboot/userboot To: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201803132254.w2DMsU2r005593@repo.freebsd.org> From: Andriy Gapon Message-ID: <45a6c658-1133-ad46-d8df-48ee5bbccddf@FreeBSD.org> Date: Wed, 14 Mar 2018 14:44:37 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <201803132254.w2DMsU2r005593@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 12:44:50 -0000 On 14/03/2018 00:54, Gleb Smirnoff wrote: > Author: glebius > Date: Tue Mar 13 22:54:29 2018 > New Revision: 330883 > URL: https://svnweb.freebsd.org/changeset/base/330883 > > Log: > Fix typo that misteriously passes compilation. > > Modified: > head/stand/userboot/userboot/main.c > > Modified: head/stand/userboot/userboot/main.c > ============================================================================== > --- head/stand/userboot/userboot/main.c Tue Mar 13 21:42:38 2018 (r330882) > +++ head/stand/userboot/userboot/main.c Tue Mar 13 22:54:29 2018 (r330883) > @@ -159,7 +159,7 @@ extract_currdev(void) > //bzero(&dev, sizeof(dev)); > > #if defined(USERBOOT_ZFS_SUPPORT) > - CT_ASSERT(sizeof(struct disk_devdesc) >= sizeof(struct zfs_devdesc)); > + CTASSERT(sizeof(struct disk_devdesc) >= sizeof(struct zfs_devdesc)); > if (userboot_zfs_found) { > struct zfs_devdesc zdev; It seems that this was compiled to a call to an external CT_ASSERT function. Probably not enough warning flags to fail on a function without a prototype? Also, not sure how it worked at run-time. Maybe userboot.so is linked and loaded in such a way that it allows undefined symbols as long as they are not used. So, probably extract_currdev() just didn't get called. Anyway, thank you for spotting and fixing. -- Andriy Gapon