Date: Fri, 5 Aug 2016 00:59:07 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419614 - head/net-mgmt/netams Message-ID: <854495f4-7b47-a5b4-abe0-59624713a28d@FreeBSD.org> In-Reply-To: <201608041418.u74EIXB3055452@repo.freebsd.org> References: <201608041418.u74EIXB3055452@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5/08/2016 12:18 AM, John Marino wrote: > Author: marino > Date: Thu Aug 4 14:18:33 2016 > New Revision: 419614 > URL: https://svnweb.freebsd.org/changeset/ports/419614 > > Log: > net-mgmt/netams: reset maintainer, expire, make less broken > > First, the port already has 3 maintainer timeouts going back years, so > go ahead and reset maintainership. > > Second, it's broken on FreeBSD 10 and newer. > > Third, the options were broken (e.g. USES defined after <options>, > <pre> and <post> also used with options. I tweaked this some (untested) > > Fourth: The pcap specification is ambiguous. (I removed it). [1] > > The entire port is in really bad shape so set it for removal in > two weeks. I think 2 weeks is too short for users who may use this and in general. Can you please set this to at least 3 months, so there is an opportunity for users to see the 'port is unmaintained' message and call to action. > PR: 211578 [1] > > Modified: > head/net-mgmt/netams/Makefile > > Modified: head/net-mgmt/netams/Makefile > ============================================================================== > --- head/net-mgmt/netams/Makefile Thu Aug 4 14:05:19 2016 (r419613) > +++ head/net-mgmt/netams/Makefile Thu Aug 4 14:18:33 2016 (r419614) > @@ -3,16 +3,21 @@ > > PORTNAME= netams > PORTVERSION= 3.4.5 > -PORTREVISION= 3 > +PORTREVISION= 4 > CATEGORIES= net-mgmt > MASTER_SITES= http://www.netams.com/files/ > > -MAINTAINER= jura@netams.com > +MAINTAINER= ports@FreeBSD.org > COMMENT= Network Traffic Accounting and Monitoring Software > > -LICENSE= GPLv2 > +BROKEN_FreeBSD_10= PR 197249 > +BROKEN_FreeBSD_11= PR 197249 > +BROKEN_FreeBSD_12= PR 197249 See Bugzilla Issue: 197249 might be clearer for users who dont know what a PR is. > +DEPRECATED= unmaintained, broken on most FreeBSD platforms Although 'most' could be argued to be technically true, only 10.x and 9.x are supported production branches at the moment, and only 50% of those is broken. Broken on FreeBSD >= 10 (as mentioned in your commit log) is more accurate. > +EXPIRATION_DATE= 2016-08-18 > > -LIB_DEPENDS= libpcap.so:net/libpcap > +LICENSE= GPLv2 > > SSP_UNSAFE= kernel module does not support ssp > USE_SUBMAKE= yes > @@ -32,6 +37,7 @@ CGI_DESC= Install admin/user CGI scripts > OPTIONS_SUB= yes > PGSQL_USES= pgsql > MYSQL_USE= MYSQL=yes > +CGI_USES= jpeg > > .include <bsd.port.options.mk> > > @@ -73,7 +79,6 @@ RUN_DEPENDS+= p5-GD>=0:graphics/p5-GD \ > p5-Crypt-GeneratePassword>=0:security/p5-Crypt-GeneratePassword > > LIB_DEPENDS+= libgd.so:graphics/gd > -USES+= jpeg > > . if ${PORT_OPTIONS:MPGSQL} > RUN_DEPENDS+= p5-DBD-Pg>=0:databases/p5-DBD-Pg > @@ -136,10 +141,4 @@ do-install: > .endif > ${INSTALL_MAN} ${MAN_8:S|^|${WRKSRC}/doc/|} ${STAGEDIR}${PREFIX}/man/man8 > > -.include <bsd.port.pre.mk> > - > -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000000 > -BROKEN= does not build on 10.x+ > -.endif > - > -.include <bsd.port.post.mk> > +.include <bsd.port.mk> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?854495f4-7b47-a5b4-abe0-59624713a28d>