From owner-freebsd-acpi@FreeBSD.ORG Tue Mar 30 09:53:50 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA21B1065670 for ; Tue, 30 Mar 2010 09:53:50 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id 72CFB8FC16 for ; Tue, 30 Mar 2010 09:53:50 +0000 (UTC) Received: by bwz8 with SMTP id 8so5463294bwz.3 for ; Tue, 30 Mar 2010 02:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=Ak0/gKGJLRsrqheqeg7tONk5c7q+r/wqqQPV8umJVYo=; b=vcp/QGNI51yVpu/R8l6vCWrmGZZ+7MOEDv0jBU0JGyeDI3D2f7Geu9GJc/mwyLBeVf UerAN9CN8EovfzplYGl0hEit0HaPeG2UFpXb4XYSVRRLsMCBMJurVh1YuC8Vibzj0Lv6 /yI18HTswll5b0ks9pVQ7/JJM8ktUOCnS0vmQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=wrTwW0ZzVGSr4DYlTSczBUXmJNbO9oA8PRMtVjC1hYWHsaDSggprm6coUJ+jMQgQ4F 37BqWe0VjERkvuHT78jiBcRkg7Ln8d7liBxYWbb9jjMguD6U+Zv9QjA9tvQfVkxefQZa o0lJUGnk6uH7KKXRLbDA5mD4a2p+/uRhxWrQw= Received: by 10.204.74.32 with SMTP id s32mr1914439bkj.148.1269942829412; Tue, 30 Mar 2010 02:53:49 -0700 (PDT) Received: from [10.0.10.2] (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by mx.google.com with ESMTPS id l1sm46503114bkl.14.2010.03.30.02.53.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Mar 2010 02:53:48 -0700 (PDT) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <4BB1BEE8.8070505@obluda.cz> Date: Tue, 30 Mar 2010 10:53:46 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4BB170E7.3030407@obluda.cz> <8D820BAA-C1B9-408C-AAF3-EA69612D2C46@freebsd.org> <4BB1BEE8.8070505@obluda.cz> To: Dan Lukes X-Mailer: Apple Mail (2.1078) Cc: freebsd-acpi@freebsd.org Subject: Re: Brightness change on notebook that follow ACPI specification (par. B.7) X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 09:53:51 -0000 On 30 Mar 2010, at 10:05, Dan Lukes wrote: > On 03/30/10 10:47, Rui Paulo: >>> Most notebooks have special keys (mostly Fn+something) to change = brightness of LCD display. >>> Some of them (my notebok, for example) follows the ACPI = specification (paragraph B.7) how to announce the user request for = brightness change to OS. >>> I implemented such handling as part of acpi-video module. >=20 >> I see nothing wrong with this patch and I think it can be committed, = but I would like others to take a look. >=20 > Thanks. Code review needs to be done also, but it would be nice to = have more "yes, it works with my NB and OS ?.??" reports at this phase = ... >=20 > Did you tried it ? Which notebook and FreeBSD version ? I haven't tried it. -- Rui Paulo