From owner-svn-src-all@FreeBSD.ORG Sat Dec 26 20:44:28 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED6C7106566C; Sat, 26 Dec 2009 20:44:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 562508FC12; Sat, 26 Dec 2009 20:44:27 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id nBQKiORt076828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 26 Dec 2009 22:44:24 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id nBQKiOh3039795; Sat, 26 Dec 2009 22:44:24 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id nBQKiORt039794; Sat, 26 Dec 2009 22:44:24 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 26 Dec 2009 22:44:24 +0200 From: Kostik Belousov To: Joseph Koshy Message-ID: <20091226204424.GE2170@deviant.kiev.zoral.com.ua> References: <200912261358.nBQDwqq4011999@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iRaAnoDFBoP0sW/E" Content-Disposition: inline In-Reply-To: <200912261358.nBQDwqq4011999@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201021 - in head/sys: dev/hwpmc sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Dec 2009 20:44:29 -0000 --iRaAnoDFBoP0sW/E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + freepath = NULL; > + pmc_getfilename(vp, &fullpath, &freepath); > + last_vp = vp; > + vrele(vp); > + vp = NULL; You should do VFS_LOCK_GIANT/VFS_UNLOCK_GIANT around vrele(), since vrele() may need to acquire vnode lock and inactivate the vnode. --iRaAnoDFBoP0sW/E Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAks2dacACgkQC3+MBN1Mb4hgjgCfYCoG+4+KFcOv8ztmPEFJ/4b5 kH4Anjxf5VPh5wfio4NwnArkLxfk/AAB =xdWD -----END PGP SIGNATURE----- --iRaAnoDFBoP0sW/E--