From nobody Wed Feb 15 09:31:39 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PGtBc1xfWz3rY0h; Wed, 15 Feb 2023 09:31:52 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PGtBZ4Y5Tz3yv4; Wed, 15 Feb 2023 09:31:50 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=FLkaRBrX; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com; dmarc=pass (policy=none) header.from=bidouilliste.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1676453502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjuL/tkuDtocShAhi6RdF0l+5JVmj6PdbC/rUuQJTZM=; b=FLkaRBrXtYjrapDQq7hK016pVlMV5JzBlGNO2kxSzkYoPevin5yo8vtRoiC6d4GbSRMiyw UcxU3vKNH95dYcqdt90a8KyQL1s1wpUfGCfrwixFazjg8SlL35+tqSYwA+t6mSNxuqW7GF b31rXwsOneiu6FUOwZBaNXuyqkQcUk8= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 8f9cf688 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 15 Feb 2023 09:31:42 +0000 (UTC) Date: Wed, 15 Feb 2023 10:31:39 +0100 From: Emmanuel Vadot To: Alan Somers Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7919c76dbdd2 - main - bsdinstall: use gpt/efiboot0 label in /etc/fstab Message-Id: <20230215103139.c66c65a80b9be787deaa36a2@bidouilliste.com> In-Reply-To: <202205241917.24OJHipu099732@gitrepo.freebsd.org> References: <202205241917.24OJHipu099732@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@FreeBSD.org,dev-commits-src-all@FreeBSD.org]; DKIM_TRACE(0.00)[bidouilliste.com:+]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[manu]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4PGtBZ4Y5Tz3yv4 X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hello Alan, On Tue, 24 May 2022 19:17:44 GMT Alan Somers wrote: > The branch main has been updated by asomers: > > URL: https://cgit.FreeBSD.org/src/commit/?id=7919c76dbdd20161247d1bfb647110d87ca5ee0f > > commit 7919c76dbdd20161247d1bfb647110d87ca5ee0f > Author: Alan Somers > AuthorDate: 2022-05-24 18:24:12 +0000 > Commit: Alan Somers > CommitDate: 2022-05-24 19:17:10 +0000 > > bsdinstall: use gpt/efiboot0 label in /etc/fstab > > Otherwise, boot will hang if the numbering of disks has changed since > initial install. > > MFC after: 2 weeks > Sponsored by: Axcient > Reviewed by: brd > Differential Revision: https://reviews.freebsd.org/D35309 So, I understand the initial problem but this causes a new one. efibootmgr is now confused when you ask to print the unix path of the ESP because the device resolved is still ada0p1 (for example) and since it's not mounted anymore as the label is used we can't discover the path to the mounted ESP. Since it's now in 13.2 we've just noticed that at work. We will parse glabel but it's really horrible to parse and it be good to have efibootmgr -E -p working again on a fresh install. Cheers, -- Emmanuel Vadot