From nobody Sun May 4 22:01:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZrJXF1MdYz5vLyW; Sun, 04 May 2025 22:01:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZrJXF0gPyz3v70; Sun, 04 May 2025 22:01:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746396093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L7xirmHKOOmXGhY2BAj1Kx1IfalfqbdePjDYLoAZSis=; b=CL4IzxClEjny/YnhHabGcp6Ry6WDpxlmYJI115At8EEfFnnlqludhKO4jVXH2aCX8Bd+Ko r0V4S2ACFumUsl8ooESB1K2rBQ4bSJ/BLod+7l7E2tcXVmzwNy79Q0HmO+5ETVAOqok747 JcuC7k8ig3e8/hC9hqJrl78psiuc4HOgxYCGvh+U0qM0W8rL24PjFzoKB4twlPi9OsJflr 4fVQAP91ET4jq6qRIwt67jVRRVwp4reGE6IWZQecyAjINZzBrZkI5tvsTJlzyv0WDgA8HL AX2wtciEUCfE6jQ/soL8b9EHXRqKl8ZSPHUU6C2PzA5JgjlV3amUMo9CTnoJig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746396093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L7xirmHKOOmXGhY2BAj1Kx1IfalfqbdePjDYLoAZSis=; b=oZSM1g9u3iOhVX8UNHglQr4a1plDRDL01jeRF4PC2YcJmFWJLN7MbTIMBG1b1ejzQzPgdL sYkA3rzaYjuzqzZAlGZbBBFjLclsJ2Kp4D15/6OKKb6VcVKQLb5/T6ErC+fGXNHdPlkJzJ XhZAS2Hg+ljkyetZuYDKIttDorU7rc/hcG957/RlNLY/PWcGTMu7FuE7VPp95RqFiYkmPS XUQF3ni5xNUovxraqg6uuHh5ZKXB06oKhtDMbGTGrODtGZnTRD7CsPsbombaOeklXHLrSx wWMd/45UpEkUdFnbmSV09chy5TP07n74NgTUbTF3jAB+Dtl7PL9t70gUBZADsA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746396093; a=rsa-sha256; cv=none; b=pQZNvNcNcF7jMm4SebW1B6ZeqR+tgDRutMUCwzwonNVqFnQLCOKevCXjAUrHVz3LaMq3tV SmAw2M8RgABlfh/uVeLdsB90MKXgU6JkT0RtTutuBY/iDqFCsUDO3UD5hYQw8vO8cspgvo OEQcOwMXyA39ReWQCuE3C1QImE4yUBQsO5de70ME9dmwm+mUneRcZCScKHSsZfEPZF+9E6 rVUIy95CpxoWgL+C94kkIOVDiTBbJWhxhXHzJy9gE77Cre9NqI93nnedF4Bei/6ys9V/2x sM/fBTz6Bin19vcJqJ0Ql92KynDsOlfR7BtsD8L5kq2s0Z51tv4/m6O9QhbxPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZrJXF0DsnzmKF; Sun, 04 May 2025 22:01:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 544M1WHn016827; Sun, 4 May 2025 22:01:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 544M1WNn016825; Sun, 4 May 2025 22:01:32 GMT (envelope-from git) Date: Sun, 4 May 2025 22:01:32 GMT Message-Id: <202505042201.544M1WNn016825@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: f61844833ee8 - main - vfs_vnops.c: Make O_NAMEDATTR Solaris compatible List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f61844833ee8e39f7568b27f562d7e26897bb73d Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=f61844833ee8e39f7568b27f562d7e26897bb73d commit f61844833ee8e39f7568b27f562d7e26897bb73d Author: Rick Macklem AuthorDate: 2025-05-04 21:58:56 +0000 Commit: Rick Macklem CommitDate: 2025-05-04 21:58:56 +0000 vfs_vnops.c: Make O_NAMEDATTR Solaris compatible When the O_XATTR flag is used in a Solaris open(2), the named attribute directory is created, if it does not already exist. (Solaris does not require or allow O_CREAT for this case.) The consensus on the mailing list was that O_NAMEDATTR should behave the same way, as in "create the named attribute directory if it does not exist even if O_CREAT is not specified. This patch makes this change. Note that CREATENAMED is still useful for the NFSv4 server. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D50139 Fixes: 2ec2ba7e232d ("vfs: Add VFS/syscall support for Solaris style extended attributes") --- sys/kern/vfs_vnops.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index f1d3ba2ac08b..eaa1d298bdc6 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -208,11 +208,8 @@ open2nameif(int fmode, u_int vn_open_flags) res |= OPENREAD; if ((fmode & FWRITE) != 0) res |= OPENWRITE; - if ((fmode & O_NAMEDATTR) != 0) { - res |= OPENNAMED; - if ((fmode & O_CREAT) != 0) - res |= CREATENAMED; - } + if ((fmode & O_NAMEDATTR) != 0) + res |= OPENNAMED | CREATENAMED; if ((vn_open_flags & VN_OPEN_NOAUDIT) == 0) res |= AUDITVNODE1; if ((vn_open_flags & VN_OPEN_NOCAPCHECK) != 0)