From owner-svn-ports-head@freebsd.org Thu Jun 30 15:54:48 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9212B8687C; Thu, 30 Jun 2016 15:54:48 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9D98C2699; Thu, 30 Jun 2016 15:54:48 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 89C1F1319; Thu, 30 Jun 2016 15:54:48 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id B85361C83A; Thu, 30 Jun 2016 15:54:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id ZmtOiQvn-jdf; Thu, 30 Jun 2016 15:53:46 +0000 (UTC) Subject: Re: svn commit: r417364 - head/Mk/Scripts DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 2C0A91C832 To: Baptiste Daroussin References: <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Bryan Drewery Organization: FreeBSD Message-ID: <7357d0be-a706-fa30-a156-cd7e904a0c88@FreeBSD.org> Date: Thu, 30 Jun 2016 08:53:42 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8J0DtiErVibBj3tsbkoB2sMHVQjwLUUPK" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 15:54:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8J0DtiErVibBj3tsbkoB2sMHVQjwLUUPK Content-Type: multipart/mixed; boundary="IsLdQvIqMHPlaOqQXuB6ln13uxI5Un5XM" From: Bryan Drewery To: Baptiste Daroussin Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <7357d0be-a706-fa30-a156-cd7e904a0c88@FreeBSD.org> Subject: Re: svn commit: r417364 - head/Mk/Scripts References: <201606231131.u5NBVFur021580@repo.freebsd.org> <075ef3c9-89f1-8e95-c86a-bf00831c373e@FreeBSD.org> <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> In-Reply-To: <20160630054109.beqlksn3juwodf72@ivaldir.etoilebsd.net> --IsLdQvIqMHPlaOqQXuB6ln13uxI5Un5XM Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 6/29/16 10:41 PM, Baptiste Daroussin wrote: > On Wed, Jun 29, 2016 at 04:33:52PM -0700, Bryan Drewery wrote: >> On 6/23/2016 4:31 AM, Mathieu Arnold wrote: >>> Author: mat >>> Date: Thu Jun 23 11:31:15 2016 >>> New Revision: 417364 >>> URL: https://svnweb.freebsd.org/changeset/ports/417364 >>> >>> Log: >>> Extend the symlink checks to warn on absolute targets. >>> =20 >>> Sponsored by: Absolight >>> Differential Revision: https://reviews.freebsd.org/D6930 >> >> Why? This seems like noise. >=20 > Quite true as it is I overlooked it. >=20 > To ease relocatable packages (to prepare sysroot for exemple) symlinks = that > points to file within the same package should be absolute links. >=20 > After looking at this patch again I think it should be reverted and rep= laced > later by something that will check symlinks on the same plist >=20 > Best regards, > Bapt >=20 I agree with that purpose! --=20 Regards, Bryan Drewery --IsLdQvIqMHPlaOqQXuB6ln13uxI5Un5XM-- --8J0DtiErVibBj3tsbkoB2sMHVQjwLUUPK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJXdUCHAAoJEDXXcbtuRpfPRiYIANS15OAUQ92jBEpMIDmUXWMj Fd16EJRBM24DiSErEIbrATT6TTGtX+SmYmUALuNDNC5YNR1oEREKRuRPhFa74YZW fS2pF/mVqqy/Jkn46w0H3CBFHHfIaFoBnv4ozqA082qsNQlNBqH0ESvFEB7n/4Nt FUytPru+3rDQO2NkOi0GsAegJDuyluGBiYU1yb+AyTFO5+B/wpAlgWK8nBGx8kTu DDUdqc2UTE9TbnnUkeQ/cCWdndZWC/gi8TiWqyeAomqZ72Ads0WDAeJ2mfWyH5st JTVpYlu0PfuRN8f8RP+QpBSuelXfiUHs9hPrZ8gYCTpAul3Bp8UdmeW+ycQxJG8= =NDH7 -----END PGP SIGNATURE----- --8J0DtiErVibBj3tsbkoB2sMHVQjwLUUPK--