From owner-cvs-all Mon Sep 11 3:31:28 2000 Delivered-To: cvs-all@freebsd.org Received: from relay.butya.kz (butya-gw.butya.kz [212.154.129.94]) by hub.freebsd.org (Postfix) with ESMTP id 8D74A37B423; Mon, 11 Sep 2000 03:31:23 -0700 (PDT) Received: by relay.butya.kz (Postfix, from userid 1000) id A14A32876C; Mon, 11 Sep 2000 17:31:11 +0700 (ALMST) Received: from localhost (localhost [127.0.0.1]) by relay.butya.kz (Postfix) with ESMTP id 8D0DF28766; Mon, 11 Sep 2000 17:31:11 +0700 (ALMST) Date: Mon, 11 Sep 2000 17:31:11 +0700 (ALMST) From: Boris Popov To: Bruce Evans Cc: Doug Rabson , John Baldwin , Doug Rabson , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 11 Sep 2000, Bruce Evans wrote: > The KTR_EXTEND version of _TR would be reasonable if it used strncpy() > instead of snprintf(). _CTR0 seems to have an array overruns from using > memcpy() instead of strncpy(). The portability given by different _CTR > macros for different numbers of args is defeated by using gcc's variadic > macro feature in NULLFSDEBUG(). I'll replace it with KASSERT-like definition: #define NULLFSDEBUG(args) printf args with appropriate changes to the rest of the code. -- Boris Popov http://www.butya.kz/~bp/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message