From owner-svn-src-all@FreeBSD.ORG Sat Dec 17 21:59:17 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 973BA106564A; Sat, 17 Dec 2011 21:59:17 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id 4ADDD8FC12; Sat, 17 Dec 2011 21:59:17 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 6BC4C25D386E; Sat, 17 Dec 2011 21:59:16 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 853EEBD737D; Sat, 17 Dec 2011 21:59:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id wqQWi1N9w2Fi; Sat, 17 Dec 2011 21:59:14 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 28FB8BD737F; Sat, 17 Dec 2011 21:59:14 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: Date: Sat, 17 Dec 2011 21:59:13 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <398125AD-ECC7-42EB-8050-BAEC6F444F1C@lists.zabbadoz.net> References: <201112171314.pBHDEjtQ060509@svn.freebsd.org> <4EED0F99.2020306@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@freebsd.org, mdf@FreeBSD.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228625 - head/usr.bin/csup X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Dec 2011 21:59:17 -0000 On 17. Dec 2011, at 21:56 , Bjoern A. Zeeb wrote: >=20 > On 17. Dec 2011, at 21:54 , Dimitry Andric wrote: >=20 >> On 2011-12-17 22:32, mdf@FreeBSD.org wrote: >> ... >>>> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing = the >>>> shared secret, and use long long format to snprintf a time_t. >>> If casting is necessary, style prefers intmax_t or uintmax_t, since >>> those are always wide enough. >>=20 >> I don't see anything about that in style(9), maybe it should be added >> then? In any case, I only changed the %ld format to %lld, because >> time_t is int, long or long long depending on arch. Long long is = just >> the widest type required in this case. >=20 > time_t is not always int. See sparc64. gnargh, sorry. But yes we prefer a well defined type to a type that is = different per arch. %lld has constantly been a printf problem in the past. /bz --=20 Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.