From owner-cvs-all@FreeBSD.ORG Thu Mar 27 18:17:41 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E74C1065671 for ; Thu, 27 Mar 2008 18:17:41 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx24.fluidhosting.com [204.14.89.7]) by mx1.freebsd.org (Postfix) with SMTP id 1819F8FC14 for ; Thu, 27 Mar 2008 18:17:40 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 28610 invoked by uid 399); 27 Mar 2008 18:24:05 -0000 Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 27 Mar 2008 18:24:05 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <47EBE4C0.4030805@FreeBSD.org> Date: Thu, 27 Mar 2008 11:17:36 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.12 (Windows/20080213) MIME-Version: 1.0 To: Alexey Dokuchaev References: <200803242042.m2OKgSmG034282@repoman.freebsd.org> <20080325095905.GA16355@FreeBSD.org> In-Reply-To: <20080325095905.GA16355@FreeBSD.org> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Alejandro Pulver , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/alienarena Makefile distinfo pkg-descr pkg-message ports/games/alienarena/files alienarena-ded.in alienarena-sdl.in alienarena.in patch-Makefile patch-client__menu.c patch-game__acesrc__acebot.h patch-game__acesrc__acebot_nodes.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 18:17:41 -0000 Alexey Dokuchaev wrote: > On Mon, Mar 24, 2008 at 08:42:28PM +0000, Alejandro Pulver wrote: >> Only for games/alienarena: >> - Remove local patches (now integrated upstream). >> - Check for WITH_* instead of !WITHOUT_* (avoid double negation). > > I've been under impression that common practice is to check for WITH_FOO > with knobs that are default to off, and !WITHOUT_FOO that default to on. Ignore previous conventions AND common practice. :) Since OPTIONS are now fixed, you can make this work in any of the 4 possible combinations: 1. Always enable unless explicitly disabled 2. Enable only if explicitly enabled 3. Disable only if explicitly disabled 4. Always disable unless explicitly enabled Hopefully I can leave the corresponding .if() statements as an exercise for the readers? :) Personally I always use either 1 or 4, but I can imagine situations where 2 or 3 might be desirable. However if we're going to argue what the _default_ usage should be, I would argue that 1 and 4 (i.e., doing it the old way) should be the default since it doesn't leave any ambiguity at package creation time, but still lets the user have flexibility when compiling it locally. Doug -- This .signature sanitized for your protection