From owner-svn-src-all@freebsd.org Fri Mar 15 01:51:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAAA1153727A; Fri, 15 Mar 2019 01:51:23 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25C09802BE; Fri, 15 Mar 2019 01:51:23 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lf1-x132.google.com with SMTP id u9so5649829lfe.11; Thu, 14 Mar 2019 18:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=2i0A9l6SvQz8uWLImgGwIbZ8EjGWc8DtVOdzUwyI5Gw=; b=BBeyxC0YZ4XJ1RtLdx/FifLImgOOlaO1zLoLcZxMb/U3IRoGtWgH2lOva1XjsOm8es l1gSpkYtT107ND+AeDgTKnlOq+wokkfUKT9XrdL2MlIvacW3+kk/lDc20NHUqTCI+XIe UQhbosxO469cEdx0A7D09kU9FDYW/oxbfB1GFCkIlrqsLuAJc/5RU3S1HYqA74Fr4ilB yFQE2Mr72CcprtzOfy8MDhL6L2F5AHyO409cWbuouRJcfrUNDJe35Fig9ADVb2V3F71T WzfAIQdXHxp1zvV2Cz9Il7lBQTbOqYImkZc96N2Ad/oRaY17wQFFFTQIoUbiL7gMNs30 cs7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=2i0A9l6SvQz8uWLImgGwIbZ8EjGWc8DtVOdzUwyI5Gw=; b=AWjlvWY00Lis6oQKkjm5ONyRkzsuCkVIhWLb1KOmzaKDxBKTrLJZaXANm8q41G432H eQpDhorwm9LiRs5DouH6SAx1cS/cQUYSpj1aTu3uN0EVcFWmtjQHUINASTb9iJWMcMtd ZJBGM2x/9g7S59xwQBp21TROk3jRWcrrVVGtYl5jXvdMB+W2DAzh9XB2QkUm+CPEQtPK P/+1L6kuRK4C0rA6gUJvyJfdDkSqdZSmHBK4gPA6mLZJwcXmav22CSAFShBfh/jnhzHx WH5FY/5ZvQmx1LGZTOB9zaAYZmjiB3FbiXMh5kzZsUsi/cPwqthw0x0vmYTFo15bqUnV //yQ== X-Gm-Message-State: APjAAAUDbuCLdOxJsBlAfi7jrpSbXl3h7rKWevvPj9qcODTYcC9XbNMY /THHZxdKprtjXRmGFGq6mrUI4WgBixKfsKXzgJaMINiu X-Google-Smtp-Source: APXvYqz/1hEVejSMGiIrvflFaEaPpTuyIMD5GIHzzb+Kj9Y0iTbPuepNRyf6xnO9Nu8cmniNCv7QuQ3fkaAoV2IYSbU= X-Received: by 2002:a19:ed19:: with SMTP id y25mr697043lfy.80.1552614681388; Thu, 14 Mar 2019 18:51:21 -0700 (PDT) MIME-Version: 1.0 References: <201903142108.x2EL8mGv018392@repo.freebsd.org> In-Reply-To: <201903142108.x2EL8mGv018392@repo.freebsd.org> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Fri, 15 Mar 2019 09:51:09 +0800 Message-ID: Subject: Re: svn commit: r345158 - head/usr.sbin/bhyve To: Conrad Meyer Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 25C09802BE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.941,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 01:51:24 -0000 Em sex, 15 de mar de 2019 =C3=A0s 05:09, Conrad Meyer esc= reveu: > Author: cem > Date: Thu Mar 14 21:08:48 2019 > New Revision: 345158 > URL: https://svnweb.freebsd.org/changeset/base/345158 > > Log: > bhyve(8): Fix uart emulation bug > > THRE is always asserted in LSR reads, so REG_IER writes that raise > IER_ETXRDY must also set thre_int_pending. > > Reported by: Illumos, according to emaste@ > https://twitter.com/ed_maste/status/1106195949087584258 > MFC after: 2 weeks > > Modified: > head/usr.sbin/bhyve/uart_emul.c > > Modified: head/usr.sbin/bhyve/uart_emul.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.sbin/bhyve/uart_emul.c Thu Mar 14 20:32:48 2019 > (r345157) > +++ head/usr.sbin/bhyve/uart_emul.c Thu Mar 14 21:08:48 2019 > (r345158) > @@ -431,6 +431,9 @@ uart_write(struct uart_softc *sc, int offset, uint8_t > sc->thre_int_pending =3D true; > break; > case REG_IER: > + /* Set pending when IER_ETXRDY is raised (edge-triggered)= . > */ > + if ((sc->ier & IER_ETXRDY) =3D=3D 0 && (value & IER_ETXRD= Y) !=3D > 0) > + sc->thre_int_pending =3D true; > /* > * Apply mask so that bits 4-7 are 0 > * Also enables bits 0-3 only if they're 1 > > Hi cem@, FYI: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D344057 So there is some license concern around this patch, core@ reverted my first attempt to import this patch from Illumos. I guess core@ will ping you soon to do the same. There is a review made by the Illumos guys: https://reviews.freebsd.org/D19499 Pending now bhyve maintainer to approve it. Dark days, we had 2 committers trying to fix the same thing and our hands are tied. Best, --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)