From owner-svn-src-all@freebsd.org Thu Dec 22 04:54:37 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBF79C8C5F4 for ; Thu, 22 Dec 2016 04:54:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 94E70F99 for ; Thu, 22 Dec 2016 04:54:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x241.google.com with SMTP id 75so19646622ite.1 for ; Wed, 21 Dec 2016 20:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QIfpzdF2wynGF0HCBwLRm5d/rjKYGmtJ2/qzg9jB8LM=; b=XlvupZsXWOFth2Ym40vMLwwLoGhcjBZX9DdDSiO/pv4J3YIdQhgJ2BpIKCerp1h8cV bUmAX5wyGV7vBgqOILh1s45oQJVOMWguodK+YAyuPSdlbKPgWPgtBBxHGzujXsNOZw+Z 21lLZDcDtfDNWkvNnhFZDErPxmLSgavK+jOoNx7O0FHr4XDRhQUkYW4VXZdzLJbXpbOa f8vv7Qsvo8AkcA5Q/4P2c/4r8QByQBRn6xp4KwdwQ2YDCLfTo4tOK2zdsuSGcyiRcQYJ UnR6Ea48QGfbE5Ad4e12DV+FR8z7V7BzobwNiI2UNPH5utNUXhz9G+3ZkNFFaGFtPLhM B8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QIfpzdF2wynGF0HCBwLRm5d/rjKYGmtJ2/qzg9jB8LM=; b=nos4C1byqRFtQ4panZ0IvB1HdgUSZXVyPp1nZsEkqG/Sfb6osW+ZtCpx7psc8AZIZF PDQvxI7nDsooCdMNQ166AWCT2HvGESGro+qnyJfrgnkinETOrFsRxneojo/8G4lR3A+P RvLoAmivp7dcupoZAUKiPMDqCsFA1sk+EBWEGYcs77JVH+Ty1IsHSA5sf21OEGocyxZl vcyEPi5AAPTfDFwBiWhCK3493UXZ3fU7gVbNE6rPpiWBrfjMMe4D6Lv3XgOR9fZ22P+F RVxJdcjS/dzcLK0WcdlJo8+KwCRfkDR63xh/49xJy4K27ukodbxcjpR72s36QV4I80Ha f0bw== X-Gm-Message-State: AIkVDXJ+UxQKTkaXDVfrSPCcIbzfj5BPlIib/LVQ2tArK9rpLwLcGv8wTA5dd4eekf3KzQwgjL+QZnARVoDjSg== X-Received: by 10.36.58.16 with SMTP id m16mr8258559itm.85.1482382476989; Wed, 21 Dec 2016 20:54:36 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.22.135 with HTTP; Wed, 21 Dec 2016 20:54:36 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: References: <201612210829.uBL8Tijt041811@repo.freebsd.org> From: Warner Losh Date: Wed, 21 Dec 2016 21:54:36 -0700 X-Google-Sender-Auth: jg8uwx5qzHbKI9Q2qK6VXYjogI0 Message-ID: Subject: Re: svn commit: r310354 - in head/usr.sbin: . prometheus_sysctl_exporter To: Ed Schouten Cc: Adrian Chadd , Ed Schouten , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 04:54:37 -0000 On Wed, Dec 21, 2016 at 12:06 PM, Ed Schouten wrote: > Hi Adrian, > > 2016-12-21 18:32 GMT+01:00 Adrian Chadd : >> Maybe just "sysctl_export" would be fine. > > Good point. Almost all Prometheus metrics exporters use this naming scheme: > > ~80%: ${foo}_exporter > ~20%: prometheus_${foo}_exporter > > Examples; > > - https://github.com/prometheus/node_exporter > - https://github.com/ewr/elasticsearch_exporter > - https://github.com/jonnenauha/prometheus_varnish_exporter > > The reason why I went for the 'prometheus_' prefix was mainly because > of the following totally subjective reasons: > > - I didn't want to wreck tab completion. Right now if you type in > 'sysc' and press tab, it tends to complete to 'sysctl'. > - This tool is part of the base system, meaning that it will be > present even if the user did nothing special. This is why I wanted the > name to be a bit more self-documenting. > - Thinking ahead: what if we're going to add exporters for other > things as well? E.g., for Sendmail, sshd, ftpd, HAST, etc. In that > case it would be nicer if those exporters shared a common prefix. > > That said, if people truly think it's a good idea to call this > sysctl_exporter instead, then I wouldn't mind renaming it. > > Thoughts? Opinions? sysctl_ anything will have my rage filled tab completion beeps sending hate your way for years to come. Please don't do that :) Warner