Date: Thu, 17 Jun 2004 10:38:54 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Max Khon <fjoe@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf.c uipc_syscalls.c src/usr.bin/netstat mbuf.c src/lib/libc/sys sendfile.2 Message-ID: <20040617173854.GJ61448@elvis.mu.org> In-Reply-To: <200406170008.i5H08NDt085108@repoman.freebsd.org> References: <200406170008.i5H08NDt085108@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
MFC'ing a change to netstat -m's output is not acceptable. This will break scripts. Please back out the netstat change. Why are sfbuf/sendfile stats being put under mbuf stats? This is bogus, please use a different flag instead of cluttering the mbuf stats. * Max Khon <fjoe@FreeBSD.org> [040616 17:08] wrote: > fjoe 2004-06-17 00:08:23 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_4) > sys/sys mbuf.h > sys/kern uipc_mbuf.c uipc_syscalls.c > usr.bin/netstat mbuf.c > lib/libc/sys sendfile.2 > Log: > MFC: > > sendfile(2)-related statistics that can be viewed through netstat -m: > - The number of times sendfile() had to do disk I/O > - The number of times sfbuf allocation failed > - The number of times sfbuf allocation had to wait > and three sysctl's: kern.ipc.nsfbufs, kern.ipc.nsfbufspeak, > kern.ipc.nsfbufsused that also can be viewed through netstat -m. > > Submitted by: Igor Sysoev <is (at) rambler-co.ru> > > Revision Changes Path > 1.6.2.9 +50 -1 src/lib/libc/sys/sendfile.2 > 1.51.2.37 +8 -0 src/sys/kern/uipc_mbuf.c > 1.65.2.20 +6 -0 src/sys/kern/uipc_syscalls.c > 1.44.2.26 +6 -1 src/sys/sys/mbuf.h > 1.17.2.4 +16 -2 src/usr.bin/netstat/mbuf.c -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040617173854.GJ61448>