From owner-cvs-all Sun Jul 14 10:12:34 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CA3537B406 for ; Sun, 14 Jul 2002 10:12:28 -0700 (PDT) Received: from relay.pair.com (relay1.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 06A2A43E58 for ; Sun, 14 Jul 2002 10:12:27 -0700 (PDT) (envelope-from mp@FreeBSD.org) Received: (qmail 56301 invoked from network); 14 Jul 2002 17:12:25 -0000 Received: from 12-236-91-101.client.attbi.com (HELO ?10.1.1.73?) (12.236.91.101) by relay1.pair.com with SMTP; 14 Jul 2002 17:12:25 -0000 X-pair-Authenticated: 12.236.91.101 Mime-Version: 1.0 X-Sender: (Unverified) Message-Id: In-Reply-To: <20020714095839.H74633@iguana.icir.org> References: <200207141209.g6EC9XBL099971@freefall.freebsd.org> <20020714093834.E74633@iguana.icir.org> <20020714095839.H74633@iguana.icir.org> Date: Sun, 14 Jul 2002 10:12:21 -0700 To: Luigi Rizzo From: Mark Peek Subject: Re: cvs commit: src/release/picobsd/build write_mfs_in_kernel.c Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 9:58 AM -0700 7/14/02, Luigi Rizzo wrote: > > Well, I guess you could say that I complained. I'll send a request to >> the cvsmeisters for a repo copy to (yet) another location. > >you are not in need -- you just asked who could be using it >and did not positively mention anyone. >Not that i am opposed to keeping it, just i do not see any >use... Let me phrase it a bit stronger. I have used this utility in the past for PowerPC porting and I foresee myself using it in the future. I don't see a need for you to continue carrying it around in the picobsd tree (especially if you're not using it) but I object to it being totally removed from the system. > > Well, write_mfs_in_kernel does a bit more error checking to ensure > > the user isn't shooting themselves in the foot. > >the only additional check is that the area where you would 'dd' >the data is all-zero. You still have plenty of ways to shoot >yourself in the foot by passing an invalid mfs image as argument >(and if the kernel area is non-zero, you _are_ passing an invalid >argument, the kernel in this case). Sure, and I could also 'dd if=boot0 of=/dev/acd0" rather than use disklabel. Having *some* sanity checks is better than nothing. Mark To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message