From owner-svn-src-head@freebsd.org Fri Jul 6 06:08:47 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD169104182B; Fri, 6 Jul 2018 06:08:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A0F58CBCB; Fri, 6 Jul 2018 06:08:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 3FCF81F801; Fri, 6 Jul 2018 06:08:46 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id DA45E1F25; Fri, 6 Jul 2018 06:08:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id TBu9OfhLUiB2; Fri, 6 Jul 2018 06:08:42 +0000 (UTC) Subject: Re: svn commit: r336019 - in head: . usr.sbin/config DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com AF5201F20 To: Kyle Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807060111.w661B76W005640@repo.freebsd.org> From: Bryan Drewery Openpgp: preference=signencrypt Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8FAlJp hmsCGwwFCQlmAYAACgkQNddxu25Gl89UPggA2mGQp28yCUKsJ6KHFVy/lpHfoQrKF+s7HfKT U2ObVeVNX4I8ZdW1UO48mRqxEOwY8r5YSH6X06OmiqCX2aSMXg3N06/l+ztlB0+UGGlkXBjv l9/nii+bC6b8XWuu0X7Qpb9oYBK9YtoaoyuVplAmjdj/cPou65meKIaS1yDTjHh450DrW8Qg he6l0bFX4BHKTSm99U90ML7EY19B6iI2BZSqWutVsyD71oAREY6NGgDpCOIO6FS41+WeYCDR j8vsa/BiaoX2d2SBDsCwsEwe9fg5PYMi2uVIhvL6OrxnwOdB+TkgvOy5zZSNO29UG/JilZKo Ndz2wpEaUzChGGqLvcLAZQQYAQoADwIbDAUCWujOKAUJCmB7PQAKCRA113G7bkaXz6bkB/9H dUR3E0wBwMh6z0AOFDKh+PbRI9Xd4IncdhE55tNK410650a3gADIDwqz3i72GIinkgaxzpEO xP1bs7a+BeF3p5Xd6Jjk6J/nEshisgNW7VjUbJHFGs8Sf9A6oM3q4VkI/ArVo5qkZxgKs72U HSAy5NV+AdqdTrWuAL20xfQ6gA7JF35Xf8zyUM2GMl0X8ik7dJ1jMp+TB27LipqbDgamFzH9 F9hC9gur94OQ/x3nQ+mFZ1uipYHA1EdrKuhb/Ts4bN/Ezl8nmYGxc9Bw7ZBxGOTId/rEIzoe LWpAvg6dcw0T9lNfSWc6PX+kf3dOXNIdkw9NqKID8wEPe8axcGYG Organization: FreeBSD Message-ID: Date: Thu, 5 Jul 2018 23:08:39 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 06:08:47 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2 Content-Type: multipart/mixed; boundary="PX2dU4yd7wU53pG2iq7IingH7Uk4T4F3W"; protected-headers="v1" From: Bryan Drewery To: Kyle Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r336019 - in head: . usr.sbin/config References: <201807060111.w661B76W005640@repo.freebsd.org> In-Reply-To: --PX2dU4yd7wU53pG2iq7IingH7Uk4T4F3W Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/5/18 6:53 PM, Kyle Evans wrote: > On Thu, Jul 5, 2018 at 8:11 PM, Kyle Evans wrote: >> Author: kevans >> Date: Fri Jul 6 01:11:06 2018 >> New Revision: 336019 >> URL: https://svnweb.freebsd.org/changeset/base/336019 >> >> Log: >> config(8): De-dupe hint/env vars within a single file >> >> r335653 flipped the order in which hints/env files are concatenated = to match >> the order in which vars are processed by the kernel. This is the oth= er >> hammer to drop. >> >> Use nv(9) to de-dupe entries within a single `hint` or `env` file, u= sing the >> latest value specified for a key. This leaves some duplicates if a v= ariable >> is specified in multiple hint/env files or via `envvar` in a kernel = config, >> but the reversed order of concatenation (from r335653) makes this a >> non-issue as the latest-specified version will be seen first. >> >> This change also silently rewrote hint bits to use the same sanitiza= tion >> process that ian@ wrote for r335642. To the kernel, hints and env va= rs are >> basically the same thing through early boot, then get merged into th= e >> dynamic environment once kmem becomes available and the dynamic envi= ronment >> is created. They should be subjected to the same restrictions. >> >> libnv has been added to -legacy for the time being to support the bu= ild of >> config(8) with the new cnvlist API. >> >> Tested with: universe (11 host & 12 host) >> MFC after: 1 month >> >=20 > This seems to be causing pretty consistent config(8) failures on CI, > kernels with neither hints nor environment variables, that neither of > my universe builds nor any of my post-commit builds can reproduce. Can > anyone else reproduce these failures that might be willing to give me > a hint as to what kind of setup causes this? >=20 > 01:47:58 cd /usr/src/sys/arm/conf; > PATH=3D/usr/obj/usr/src/arm.armv7/tmp/legacy/usr/sbin:/usr/obj/usr/src/= arm.armv7/tmp/legacy/usr/bin:/usr/obj/usr/src/arm.armv7/tmp/legacy/bin:/u= sr/obj/usr/src/arm.armv7/tmp/usr/sbin:/usr/obj/usr/src/arm.armv7/tmp/usr/= bin:/sbin:/bin:/usr/sbin:/usr/bin > config -d /usr/obj/usr/src/arm.armv7/sys/GENERIC -I > '/usr/src/sys/arm/conf' '/usr/src/sys/arm/conf/GENERIC' > 01:47:58 config: /usr/src/sys/arm/conf/GENERIC: No error: 0 >=20 I've seen this error with broken ABI. The -I${SRCTOP}/sys on the config build may be contributing to the problem since sys/stat.h is ino64 and the builder may not be. Really should not be bringing in the source sys/ directory for any of the early host tool phases. There's some hack patterns to bring in a limited amount of headers but in this case the headers should be getting staged somewhere already. Note legacy: ${MAKE} DIRPRFX=3D${_tool}/ DESTDIR=3D${WORLDTMP}/legacy includes; \ So -IWORLDTMP/legacy/sys should find the nv headers. This is already included via: tools/build/mk/Makefile.boot:CFLAGS+=3D -I${WORLDTMP}/legacy/usr/includ= e Which is brought in for bootstrap-tools though via: MAKEFLAGS=3D"-m ${.CURDIR}/tools/build/mk ${.MAKEFLAGS}" --=20 Regards, Bryan Drewery --PX2dU4yd7wU53pG2iq7IingH7Uk4T4F3W-- --2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAls/B2cACgkQNddxu25G l8+XRgf/UjXK5BTC9nTpT8fAYLTpD0ktW98/PJRXCK9WLqis9weE7X6FKaVC8urb 5evAWS5TOLhAjoqKUCBqLhReQ/GuIPQRwQsqQq04/fjeDI5CLampLzqQYb3hSffU 8mgwx0azuDSa9RSeXCFU2pQlr5DaufGFToS2ybavDMgafC3Nzr1eLLnuryYXzBy+ QZgGIlx52O01q6Y3CLXrNpQat7iHDeWSYX8V3TMMxy0u3wzynVzqnCn6sasgPbjl Zya5Py0ggv8G4cowQrzFes5eKaQLs1zb9+6L+wkUT1RT+NtG1VAQnWgHmR11IPZx yty+HbaZK7MB/Owz1iGq3zXVEuu+UA== =l/ct -----END PGP SIGNATURE----- --2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2--