From owner-freebsd-rc@FreeBSD.ORG Tue Mar 29 20:33:07 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1102106566C; Tue, 29 Mar 2011 20:33:07 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4F8C58FC1A; Tue, 29 Mar 2011 20:33:06 +0000 (UTC) Received: by gxk28 with SMTP id 28so286906gxk.13 for ; Tue, 29 Mar 2011 13:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:in-reply-to :message-id:references:user-agent:x-openpgp-key-id :x-openpgp-key-fingerprint:mime-version:content-type; bh=65CFUj2N91H6oCIl9OgI5KBPHraF+LCoiOZ7p1fAMPA=; b=gfxGyXFYrEm0+kWSlLeNXDtbfhumoJBXy5vANblkMPsRPzhfwz5ZMZH1twoZ9+m27h 9M8x+K31zfqEEwSww8WWJltoRrZiAFCVbskTyg45jyqqmFXzPljFRlJ+dweKQaAwq4J+ nub5mwfLP49j5HBTcGBAQHzwuFg6CtYNiA45Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; b=pUTgvXYEud3W0cT7A3fB7g+N7++Stxk3xttcKl1W5xpJfGayyXFqsCshGvX5CcXYpF puK0ZCWikFDwjuBJqoTpiNgLcgUUX+QGsrOEkslj68H8JW3fsoBzjnPmA4PtucN/DXIO G4yPxJj9MD03NlYXDWvJAQyNvBjFlY1cLsLMc= Received: by 10.91.163.25 with SMTP id q25mr164632ago.189.1301430786424; Tue, 29 Mar 2011 13:33:06 -0700 (PDT) Received: from disbatch.dataix.local (adsl-99-181-153-110.dsl.klmzmi.sbcglobal.net [99.181.153.110]) by mx.google.com with ESMTPS id r8sm2724350ane.45.2011.03.29.13.33.03 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Mar 2011 13:33:04 -0700 (PDT) Sender: "J. Hellenthal" Date: Tue, 29 Mar 2011 16:32:55 -0400 From: "J. Hellenthal" To: Hiroki Sato In-Reply-To: <20110329.115900.969026047405273902.hrs@allbsd.org> Message-ID: References: <20110319012959.GA39929@atarininja.org> <20110319013155.GB39929@atarininja.org> <20110329024441.GA24720@atarininja.org> <20110329.115900.969026047405273902.hrs@allbsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: wxs@freebsd.org, freebsd-rc@freebsd.org Subject: Re: status cleanup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2011 20:33:07 -0000 On Mon, 28 Mar 2011 22:59, hrs@ wrote: > Wesley Shields wrote > in <20110329024441.GA24720@atarininja.org>: > > wx> On Fri, Mar 18, 2011 at 09:31:55PM -0400, Wesley Shields wrote: > wx> > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote: > wx> > > A co-worker noticed that the pf rc script has 'status' listed twice when > wx> > > run without any arguments. The attached patch fixes that and two other > wx> > > cases where this also happens. I've only tested the pf changes. I'd > wx> > > appreciate a review of this and maybe a commit? I can file a PR if it > wx> > > would make people feel better. > wx> > > > wx> > > I'm not subscribed to this list so I would appreciate being CC'ed on any > wx> > > replies. > wx> > > > wx> > > -- WXS > wx> > > wx> > This time with the patch attached, or you can get it at: > wx> > > wx> > http://people.freebsd.org/~wxs/rc-status-cleanup.diff > > wx> > -extra_commands="status prefer_ipv6 prefer_ipv4" > wx> > +extra_commands="prefer_ipv6 prefer_ipv4" > > For the ip6addrctl script removing "status" is wrong. This keyword > is automatically added only when ${name}_program is defined and the > ip6addrctl does not define it. > > The other two changes look good to me. If there is no objection in a > day or two, I will commit them. Thank you for your report. > > -- Hiroki > WXS, I have these applied here and to the best of my knowledge they are correct as can be. As for the status command in ip6addrctl Is it really needed ? ;) There is no daemon running here... +1week -- Regards, J. Hellenthal (0x89D8547E) JJH48-ARIN