From owner-freebsd-current  Mon Sep  9 16: 0:34 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3027937B400; Mon,  9 Sep 2002 16:00:31 -0700 (PDT)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D5BDE43E6A; Mon,  9 Sep 2002 16:00:29 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.5/8.12.5) with ESMTP id g89N0Hwr093398;
	Mon, 9 Sep 2002 16:00:21 -0700 (PDT)
	(envelope-from dl-freebsd@catspoiler.org)
Message-Id: <200209092300.g89N0Hwr093398@gw.catspoiler.org>
Date: Mon, 9 Sep 2002 16:00:17 -0700 (PDT)
From: Don Lewis <dl-freebsd@catspoiler.org>
Subject: vnode lock assertion problem in nfs_link()
To: current@FreeBSD.org, jeff@FreeBSD.org
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

nfs_link() contains the following code:

        /*
         * Push all writes to the server, so that the attribute cache
         * doesn't get "out of sync" with the server.
         * XXX There should be a better way!
         */
        VOP_FSYNC(vp, cnp->cn_cred, MNT_WAIT, cnp->cn_thread);

The problem is that vp is not locked by the caller, but VOP_FSYNC()
expects its argument to be locked.

I think we can probably just lock and unlock vp around the call to
VOP_FSYNC() ... 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message