From owner-cvs-usrsbin  Tue Sep  9 18:28:30 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id SAA22901
          for cvs-usrsbin-outgoing; Tue, 9 Sep 1997 18:28:30 -0700 (PDT)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id SAA22735;
          Tue, 9 Sep 1997 18:27:29 -0700 (PDT)
Received: from gate.lan.awfulhak.org (localhost [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id CAA20424;
	Wed, 10 Sep 1997 02:25:34 +0100 (BST)
Message-Id: <199709100125.CAA20424@awfulhak.demon.co.uk>
X-Mailer: exmh version 2.0zeta 7/24/97
To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
cc: Brian Somers <brian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/ppp command.c 
In-reply-to: Your message of "Wed, 10 Sep 1997 05:14:57 +0400."
             <Pine.BSF.3.96.970910051325.22836B-100000@lsd.relcom.eu.net> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 10 Sep 1997 02:25:34 +0100
From: Brian Somers <brian@awfulhak.org>
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> On Tue, 9 Sep 1997, Brian Somers wrote:
> 
> > brian       1997/09/09 16:13:33 PDT
> > 
> >   Modified files:
> >     usr.sbin/ppp         command.c 
> >   Log:
> >   Don't start an interactive shell from a
> >   telnet prompt.
> 
> Hmm. Are you shure it is neccessary? I think it was allowed only when
> password entered and ppp goes back to user priveledges before
> starting shell.

True, but this change just stops the following:

$ telnet localhost 3000
  ppp on mach> passwd xxxxx
  ppp ON mach> shell
  pwd
  help
  x
  exit exit exit
  ppp ON mach> quit

It doesn't block running shell commands like:

  ppp ON mach> shell mycommand

I think it would be overkill to go and allocate a pty (the only way 
to make an interactive shell work from the telnet session) when the 
user can easily just ^Z instead :-)

Of course if the telnet client is on a different machine.....

> -- 
> Andrey A. Chernov
> <ache@null.net>
> http://www.nagual.pp.ru/~ache/
> 

-- 
Brian <brian@awfulhak.org>, <brian@freebsd.org>
      <http://www.awfulhak.org>
Don't _EVER_ lose your sense of humour....