Date: Sun, 21 May 2023 19:01:27 -0400 From: Warner Losh <imp@bsdimp.com> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body. Message-ID: <CANCZdfrLXCOc%2Bxj0ycQURaSZvXj6ij3xe7oPABO9zvNvt7VTSg@mail.gmail.com> In-Reply-To: <19a57dbf-81f0-8f57-554f-1791c5303088@freebsd.org> References: <202305211621.34LGLsup059861@gitrepo.freebsd.org> <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> <21c9532e-4ca7-a7fe-1ff6-07a94cbad6ab@freebsd.org> <3066464F-E4C6-4B84-ADFF-E578AFAFE622@freebsd.org> <e802dfc0-0a16-add1-cf5d-a8811b3bd3e6@freebsd.org> <26465813-3B51-4E52-9E9D-F93A0F2AF6BD@freebsd.org> <ffb3f6ea-ef74-ebe3-884d-da567defd2e6@freebsd.org> <2BF2F7CF-82E6-4D98-800D-C35D7C29E948@freebsd.org> <ac11ff8e-eeb9-a7e6-28d3-da5c9fad6567@freebsd.org> <A66F073E-06F4-4A91-82F3-01467D7A65BC@freebsd.org> <19a57dbf-81f0-8f57-554f-1791c5303088@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000f4d7c205fc3c22b8 Content-Type: text/plain; charset="UTF-8" On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky <hselasky@freebsd.org> wrote: > On 5/21/23 23:58, Jessica Clarke wrote: > > What I disputed was your commit message, which at best is extremely > misleading and at worst makes no sense, and the necessity of the change. > > Hi Jess, > > Your request for revert has been noted, but I see no urgency in such a > revert. The code is perfectly fine either way. > Now is not the time for stubbornness. This change is easy to bring back in if it proves to be what we want. Project custom dictates requests for back out be given strong consideration unless there's a really compelling reason why that's a bad idea. (And I don't see anything like that here). Just my suggestion... Also, I think time away from the keyboard would help de-escalate things. This change isn't worth getting so worked up over. Warner > --000000000000f4d7c205fc3c22b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Sun, May 21, 2023, 4:32 PM Hans Petter Selasky <= <a href=3D"mailto:hselasky@freebsd.org">hselasky@freebsd.org</a>> wrote:= <br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord= er-left:1px #ccc solid;padding-left:1ex">On 5/21/23 23:58, Jessica Clarke w= rote:<br> > What I disputed was your commit message, which at best is extremely mi= sleading and at worst makes no sense, and the necessity of the change.<br> <br> Hi Jess,<br> <br> Your request for revert has been noted, but I see no urgency in such a <br> revert. The code is perfectly fine either way.<br></blockquote></div></div>= <div dir=3D"auto"><br></div><div dir=3D"auto"><br></div><div dir=3D"auto">N= ow is not the time for stubbornness. This change is easy to bring back in i= f it proves to be what we want. Project custom dictates requests for back o= ut be given strong consideration unless there's a really compelling rea= son why that's a bad idea. (And I don't see anything like that here= ).=C2=A0</div><div dir=3D"auto"><br></div><div dir=3D"auto">Just my suggest= ion...</div><div dir=3D"auto"><br></div><div dir=3D"auto">Also, I think tim= e away from the keyboard would help de-escalate things. This change isn'= ;t worth getting so worked up over.</div><div dir=3D"auto"><br></div><div d= ir=3D"auto">Warner</div><div dir=3D"auto"><div class=3D"gmail_quote"><block= quote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc= solid;padding-left:1ex"></blockquote></div></div><div dir=3D"auto"><div cl= ass=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0= .8ex;border-left:1px #ccc solid;padding-left:1ex"> </blockquote></div></div></div> --000000000000f4d7c205fc3c22b8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrLXCOc%2Bxj0ycQURaSZvXj6ij3xe7oPABO9zvNvt7VTSg>