Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 May 2016 14:19:24 +0000 (UTC)
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r300745 - head/usr.bin/iscsictl
Message-ID:  <201605261419.u4QEJOTv070171@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: trasz
Date: Thu May 26 14:19:24 2016
New Revision: 300745
URL: https://svnweb.freebsd.org/changeset/base/300745

Log:
  Make iscsictl(8) actually report non-zero status on errors.  The "failed"
  is negative, because the error returned from calls to ioctl(2) is negative.
  
  MFC after:	1 month
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/usr.bin/iscsictl/iscsictl.c

Modified: head/usr.bin/iscsictl/iscsictl.c
==============================================================================
--- head/usr.bin/iscsictl/iscsictl.c	Thu May 26 14:17:57 2016	(r300744)
+++ head/usr.bin/iscsictl/iscsictl.c	Thu May 26 14:19:24 2016	(r300745)
@@ -987,7 +987,7 @@ main(int argc, char **argv)
 	if (error != 0)
 		xo_err(1, "close");
 
-	if (failed > 0)
+	if (failed != 0)
 		return (1);
 
 	xo_close_container("iscsictl");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605261419.u4QEJOTv070171>