From owner-svn-src-all@freebsd.org Thu Dec 15 07:06:33 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8018FC8161A for ; Thu, 15 Dec 2016 07:06:33 +0000 (UTC) (envelope-from 010001590149368d-51a8dd17-ce30-4c65-a117-087cf47dc8a5-000000@amazonses.com) Received: from a8-13.smtp-out.amazonses.com (a8-13.smtp-out.amazonses.com [54.240.8.13]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4492E1C4E for ; Thu, 15 Dec 2016 07:06:32 +0000 (UTC) (envelope-from 010001590149368d-51a8dd17-ce30-4c65-a117-087cf47dc8a5-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=vnqrkfnvu6csdl6mwgk5t6ix3nnepx57; d=tarsnap.com; t=1481785292; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=N3n/iMMf7NYHRWE+S/0sjONA/JY4EvmSgiu8rJAjNYU=; b=VbZrZAvzfAN2alZYqP/df7QjJZNG/HGc2r61FXkqKPlcrtOAO6SMowh96T5iD3l0 zxUeaLgZyPeo0QvCd9ZKLs7/qzQvMTMHOHkLmnGnEc+1rjqW6fEcUz8BWaiAyKyCq3y nRnHGwMa+8MvdafhskYxl1h9knIbyX+mdA5cRTEo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1481785292; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=N3n/iMMf7NYHRWE+S/0sjONA/JY4EvmSgiu8rJAjNYU=; b=C9FaFI71nmj0Y35vfKbfLBL78AeU3m3oI2imuh9IgOErWMpPS2tbmTKio8c6ns/9 n7XTYSy6Mu6PjT+sq8krbRuh6wyXy3Et6+NBCCqTv8mirjvif/En5rWO/hJv+pEm9wi +7ThhD589zS+OuyTRnp7346l9Gyg0kRIHsNQ+bdE= Subject: Re: svn commit: r310086 - head/sys/dev/xen/blkfront To: Dimitry Andric , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201612141928.uBEJSJor074348@repo.freebsd.org> From: Colin Percival Message-ID: <010001590149368d-51a8dd17-ce30-4c65-a117-087cf47dc8a5-000000@email.amazonses.com> Date: Thu, 15 Dec 2016 07:01:32 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <201612141928.uBEJSJor074348@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SES-Outgoing: 2016.12.15-54.240.8.13 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 07:06:33 -0000 On 12/14/16 11:28, Dimitry Andric wrote: > Log: > In xbd_connect(), use correct scanf conversion specifiers for the > feature_barrier and feature_flush variables. Otherwise, adjacent > variables on the stack, such as sector_size, may be overwritten, with > disastrous results. Thanks! Did you happen to notice what stack variable (if any?) was being overwritten under clang 3.8.0? Just wondering if there might be some undiscovered issue lurking in FreeBSD releases which will cause other less obvious problems. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid