From owner-svn-ports-all@FreeBSD.ORG Thu Jan 31 23:34:48 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E90CE42F for ; Thu, 31 Jan 2013 23:34:48 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-x231.google.com (mail-la0-x231.google.com [IPv6:2a00:1450:4010:c03::231]) by mx1.freebsd.org (Postfix) with ESMTP id 3F799AE0 for ; Thu, 31 Jan 2013 23:34:48 +0000 (UTC) Received: by mail-la0-f49.google.com with SMTP id fs13so2329010lab.8 for ; Thu, 31 Jan 2013 15:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=ZVQMOavIMRMn8wyLYiQbB70XCirbrPb5PXJZQNuL37U=; b=jYMV19T4O7CMFVzyxCCQsUPlDQE561Il79Ir8FNs1Uw7qkq+bDfSFjRVHAe2WS+C22 EbClMCAGzkiROfbaaNrKxw+Cbnj6GdOsIhdXspFClNWoJW2KTEQEK0tbkY4DCp7SpoTy 42QByZDPkG6GKs0hWRJ2GdgLsztBcJjxbV4po= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=ZVQMOavIMRMn8wyLYiQbB70XCirbrPb5PXJZQNuL37U=; b=dn3Pi5c3+1edh/nB3BB1ieDFlm9/yWYbA+srwZGnOHhR64lJz/TKmUo0MydNofNOB0 kchuUSHhRkVFLphZFHW9afpv+LQZsIu9VTnBDtjGCdJiyh6erpNXWTSprALuRM+nARWS 2cdJETzRKoy7vlGKPWLg/uT2ePEshfaWCx0wP/M4dmFC8+PQuj40NIUScC9s3y5kcrRf KS7lhY6iBHbLQcON6IyJI2mZ6rsgrFy9ovN5gebIztNjKA+wRMwy38vH+v4Ely5Dx/XP yVMk95kKkFk4eQoJXXJo/Nbwf8U0ii/4oM+xVq/HzZLW3RChhLQQ4JIzzgv2RMisya+/ hKyg== X-Received: by 10.112.17.194 with SMTP id q2mr4017028lbd.7.1359675287014; Thu, 31 Jan 2013 15:34:47 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.100.164 with HTTP; Thu, 31 Jan 2013 15:34:15 -0800 (PST) In-Reply-To: <510ACB0F.9040402@FreeBSD.org> References: <201301311914.r0VJE8R8091684@svn.freebsd.org> <510ACB0F.9040402@FreeBSD.org> From: Eitan Adler Date: Thu, 31 Jan 2013 18:34:15 -0500 X-Google-Sender-Auth: k6APUs7hMDy8nwf8nQkF-0uGAJ0 Message-ID: Subject: Re: svn commit: r311324 - in head: . misc/amanda-server misc/amanda25-server misc/amanda26-server misc/amanda32-server misc/instant-server net-im/kpopup net-im/linpopup net/jags net/lanbrowsing net/pro... To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkEj7BxqWj4nLdhV4qJQL0RzVsa5/UVO3mc2rhQXe/nyn+XnXBBCpAZn+QxBO8bd4giy+Zp Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, "Timur I. Bakeyev" , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2013 23:34:49 -0000 On 31 January 2013 14:50, Bryan Drewery wrote: > On 1/31/2013 1:14 PM, Timur I. Bakeyev wrote: >> .if defined (WITH_SAMBA) >> -SAMBA_PORT?= samba34 >> +SAMBA_PORT?= samba36 >> BUILD_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT} >> RUN_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT} >> -CONFIGURE_ARGS+= --with-smbclient=${PREFIX}/bin/smbclient >> +CONFIGURE_ARGS+= --with-smbclient=${LOCALBASE}/bin/smbclient > > Shouldn't PREFIX be respected and LOCALBASE just the default? This diff is correct. PREFIX is where samba will be installed to. LOCALBASE refers to where things are already installed. In this case smbclient is a build and run depend, which means is already installed (and therefore in LOCALBASE). I wish the commit log were more clear. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams