From owner-freebsd-bugs@freebsd.org Tue Mar 7 21:39:19 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF8AFD0146B for ; Tue, 7 Mar 2017 21:39:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AF1901211 for ; Tue, 7 Mar 2017 21:39:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v27LdJIG075234 for ; Tue, 7 Mar 2017 21:39:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 217620] ipfw flow specification parsing Date: Tue, 07 Mar 2017 21:39:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lutz@donnerhacke.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2017 21:39:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217620 Bug ID: 217620 Summary: ipfw flow specification parsing Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: lutz@donnerhacke.de Parsing of port-numbers explicitly set to "0" does not work. BTW: The whole code is broken for parsing named ports. How to repeat: root@server:~ # ipfw table test create type flow:src-ip,src-port,dst-ip,dst-port,proto root@server:~ # ipfw table all info --- table(test), set(0) --- kindex: 1, type: flow:src-ip,proto,src-port,dst-ip,dst-port references: 0, valtype: legacy algorithm: flow:hash items: 0, size: 296 root@server:~ # ipfw table test add 0.0.0.0,0,0,0.0.0.0,0 ipfw: Unknown service: 0 After the patch: root@server:~ # ipfw table test add 0.0.0.0,0,0,0.0.0.0,0 added: 0.0.0.0,0,0,0.0.0.0,0 0 root@server:~ # ipfw table test list --- table(test), set(0) --- 0.0.0.0,0,0,0.0.0.0,0 0 --- sbin/ipfw/ipfw2.h (revision 314807) +++ sbin/ipfw/ipfw2.h (working copy) @@ -1236,12 +1269,11 @@ if ((p =3D strchr(arg, ',')) !=3D NULL) *p++ =3D '\0'; - if ((port =3D htons(strtol(arg, NULL, 10))) =3D=3D = 0) { + port =3D htons(strtol(arg, &pp, 10)); + if(*pp !=3D '\0') { if ((sent =3D getservbyname(arg, NULL)) =3D= =3D NULL) - errx(EX_DATAERR, "Unknown service: = %s", - arg); - else - key =3D sent->s_port; + errx(EX_DATAERR, "Unknown service: = %s", arg); + port =3D sent->s_port; } tfe->sport =3D port; @@ -1280,12 +1312,11 @@ if ((p =3D strchr(arg, ',')) !=3D NULL) *p++ =3D '\0'; - if ((port =3D htons(strtol(arg, NULL, 10))) =3D=3D = 0) { + port =3D htons(strtol(arg, &pp, 10)); + if (*pp !=3D '\0') { if ((sent =3D getservbyname(arg, NULL)) =3D= =3D NULL) - errx(EX_DATAERR, "Unknown service: = %s", - arg); - else - key =3D sent->s_port; + errx(EX_DATAERR, "Unknown service: = %s", arg); + port =3D sent->s_port; } tfe->dport =3D port; --=20 You are receiving this mail because: You are the assignee for the bug.=