From owner-freebsd-current Sat Feb 1 15:21:58 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B7D4E37B401 for ; Sat, 1 Feb 2003 15:21:56 -0800 (PST) Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.157.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEA7A43F79 for ; Sat, 1 Feb 2003 15:21:55 -0800 (PST) (envelope-from mark@grondar.org) Received: from storm.FreeBSD.org.uk (Ugrondar@localhost [127.0.0.1]) by storm.FreeBSD.org.uk (8.12.6/8.12.6) with ESMTP id h11NLiLf036251; Sat, 1 Feb 2003 23:21:44 GMT (envelope-from mark@grondar.org) Received: (from Ugrondar@localhost) by storm.FreeBSD.org.uk (8.12.6/8.12.6/Submit) with UUCP id h11NLh4g036250; Sat, 1 Feb 2003 23:21:43 GMT X-Authentication-Warning: storm.FreeBSD.org.uk: Ugrondar set sender to mark@grondar.org using -f Received: from grondar.org (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.6/8.12.6) with ESMTP id h11NFVaX028348; Sun, 2 Feb 2003 01:15:31 +0200 (SAST) (envelope-from mark@grondar.org) From: Mark Murray Message-Id: <200302012315.h11NFVaX028348@grimreaper.grondar.org> To: Julian Elischer Cc: current@freebsd.org Subject: Re: Style fixups for proc.h In-Reply-To: Your message of "Sat, 01 Feb 2003 15:04:32 PST." Date: Sat, 01 Feb 2003 23:15:31 +0000 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Julian Elischer writes: > I don't know about the protection with a '_'. > > It's not standard and usually the name matches that used in the actual > function. When the prototype parameter name matches a local variable, the C compiler (and lint) whine about clashes between names in local/global namespace. 2 ways to fix this are to "protect" the prototype argument names with the "_", or to remove the argument name altogether. proc.h has no clear guidance, in that recent commits don't stick to the established style of the file. Some newish prototypes have a mixture of named/unnamed args in the same function. While I was making all prototypes' args named, I protected them. I'd like to fix the warnings, and I'd like the file to be consistent WRT argument naming. > It's certainly not part of style(9) that I've ever noticed > and it's generally noy done that way.. is there a move to do this on all > the other files? There is a move to fix lint(1) warnings. M -- Mark Murray iumop ap!sdn w,I idlaH To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message