From owner-svn-src-all@freebsd.org Fri Nov 20 11:12:42 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB0A8A332FF; Fri, 20 Nov 2015 11:12:42 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 9AF3B1A18; Fri, 20 Nov 2015 11:12:42 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 993A01CD2; Fri, 20 Nov 2015 11:12:42 +0000 (UTC) Date: Fri, 20 Nov 2015 11:12:42 +0000 From: Alexey Dokuchaev To: Oliver Pinter Cc: Craig Rodrigues , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r291090 - head/usr.bin/vmstat Message-ID: <20151120111242.GA47921@FreeBSD.org> References: <201511200515.tAK5FZT8037263@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2015 11:12:42 -0000 On Fri, Nov 20, 2015 at 12:01:36PM +0100, Oliver Pinter wrote: > On 11/20/15, Craig Rodrigues wrote: > > New Revision: 291090 > > URL: https://svnweb.freebsd.org/changeset/base/291090 > > > > Log: > > Convert vmstat to use libxo. > > > > [...] > > @@ -774,49 +804,64 @@ dovmstat(unsigned int interval, int reps > > > > fill_vmmeter(&sum); > > fill_vmtotal(&total); > > - (void)printf("%1d %1d %1d", > > + xo_open_container("processes"); > > + xo_emit("{:runnable/%1d} {:waiting/%ld} " > > + "{:swapped-out/%ld}", > > Are these %1d -> %ld conversions here intended or a typo? Oliver, please learn how to quote email when replying properly, thank you. ./danfe