From owner-freebsd-current@FreeBSD.ORG Sat Sep 20 22:07:27 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9924116A4B3 for ; Sat, 20 Sep 2003 22:07:27 -0700 (PDT) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61BEC43FE1 for ; Sat, 20 Sep 2003 22:07:26 -0700 (PDT) (envelope-from eischen@vigrid.com) Received: from mail.pcnet.com (mail.pcnet.com [204.213.232.4]) by mail.pcnet.com (8.12.10/8.12.1) with ESMTP id h8L57FgG001586; Sun, 21 Sep 2003 01:07:15 -0400 (EDT) Date: Sun, 21 Sep 2003 01:07:15 -0400 (EDT) From: Daniel Eischen X-Sender: eischen@pcnet5.pcnet.com To: "M. Warner Losh" In-Reply-To: <20030920.204425.25098720.imp@bsdimp.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@freebsd.org cc: h@schmalzbauer.de Subject: Re: ports and -current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: deischen@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2003 05:07:27 -0000 On Sat, 20 Sep 2003, M. Warner Losh wrote: > In message: <20030921021940.GB28195@freebsd1.cimlogic.com.au> > John Birrell writes: > : On Sat, Sep 20, 2003 at 08:06:25PM -0600, M. Warner Losh wrote: > : > But it was completely removed. That sounds like the consensus wasn't > : > followed. Why was it then removed? > : > : It got discussed a bit more after the removal. That was the time when the > : GCC people got involved. The discussions where on FreeBSD public lists. > > Yes. However, it is clear that the pain level wasn't adequately > disclosed at the time of the removal. > > : > So we change -pthread to mean "link in the default threading package, > : > with whatever magic is necessary for that package" rather than "link > : > in libc_r instead of libc". > : > : A better way is to just link to the thread package you want. Keep knowledge > : of thread libraries outside GCC. There really is nothing simpler that > : adding -lc_r or -lpthread or -lmyownthreadlib. No magic required. > > Works for me. > > : > Then why was it completely removed? > : > : Dan removed it because it wasn't needed and nobody said anything otherwise. > > Time has proven the "not needed" part was premature. > > : > At the very least, we should put it back as a noop. The timing on > : > this really sucks because it breaks the ports tree for an extended > : > period of time. While the fixes are simple, they haven't been made > : > yet. The fact that the tree is frozen makes it seem like a really bad > : > time to make the change. > : > : Yes, I think it should go back as a noop (mostly to satisfy the GCC > : people though). > > Sounds like we're in violent agreement. But you seem to thing -pthread == NOOP unbreaks ports ;-) -- Dan Eischen