From nobody Tue Feb 28 17:00:43 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PR3XX1bjpz3tgnp for ; Tue, 28 Feb 2023 17:00:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PR3XX0b1Sz3NmJ for ; Tue, 28 Feb 2023 17:00:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677603644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IatppvAzPv+S6RI+W/h8CThg+crER5duX5aF/G+gU4s=; b=OPR1GLfYNz8huAez3+3p/6C0h+Xn549bqUVb0ZaujyCubEHLIKPHzJx/hy6428zObjtqz3 fGod6eESiP4grBupiq/bKe9ND+oRr+OCMLZHgf5vK8Mrxmk9qsdlT6et1tRXFL3Z8nWBv3 TdxX6/qloZ4UZtXomJz0KRbCM+Pk0gfGwyjpaHIZX9trEkrak/IT8Ka83cljP82x02X20t ihacFh5byGSaM8zyGeY4YzBh1D2Y049ZylJYaHWYGjHyb6E+Zt0OC0IYVk/S2aWqtxXLlC 6N5Ze+phKlBAkym0OQe40MwEHmjc2XVmIG4/4g/+8HL3rT8EMsZl39FcWCz3Ew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677603644; a=rsa-sha256; cv=none; b=wNdTjwvYB0ConVn4FSDoVd/uWaje9DzUsnN5cTtIbcKzEQihkHwDcPszbnnENl2jgUgKMn lXPNPll4EWrpHgaf9XUYKLdzsQpQLxPISjKt7lbHytdsQ+SvvTuv6k0c0M5xUmQ7r9Lqwg mL5utGa6FyB9wTnlXk4QaURlIwrdyEHVeUbLAH6j1oEpcbFvoROzdLOJf1RYSoVrVJRSMp tGCxseui9UhqEohAohTlvmd1R63X91sEcsnIASt5MxmI3gDrr4+USGvGwU+FsSRWfQv0dp ZYXNRRey1xdhTD9V5N9+dmN3TzFniN/Jgw6QzZ27xT3A11KCT+kRId4N5E8a6Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PR3XW6ngnz1DtN for ; Tue, 28 Feb 2023 17:00:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31SH0hn5018956 for ; Tue, 28 Feb 2023 17:00:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31SH0hEh018955 for bugs@FreeBSD.org; Tue, 28 Feb 2023 17:00:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 267464] periodic 310.accounting enables accounting even if it is disabled in rc.conf Date: Tue, 28 Feb 2023 17:00:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267464 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D9ab40bc40d4a07e1a9f3622a7779312ca= 2466b55 commit 9ab40bc40d4a07e1a9f3622a7779312ca2466b55 Author: John Grafton AuthorDate: 2023-02-28 16:49:40 +0000 Commit: Warner Losh CommitDate: 2023-02-28 16:59:34 +0000 310.accounting: Verify process accounting is active before log rotation. This corrects a bug in which the daily periodic script '310.accounting' attempts to rotate logs via /etc/rc.d/accounting by calling onerotate_logs function. The rotate logs function turns accounting back on regardless of what acccounting_enable is set to in /etc/rc.conf. This is due to checkyesno always returning YES since rotate logs is called with the 'one' prefix. In effect, accounting will always be turned back on once a day even if it is disabled and stopped by hand. The fix was simple, just check if accounting is before rotating logs and if it is, don't attempt the rotate. PR: 267464 Reviewed by: imp, hps (lgtm, not approval), Mina Gali=C4=87 Pull Request: https://github.com/freebsd/freebsd-src/pull/648 Differential Revision: https://reviews.freebsd.org/D37434 usr.sbin/periodic/etc/daily/310.accounting | 5 +++++ 1 file changed, 5 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=