From owner-svn-src-all@FreeBSD.ORG Thu Jan 15 20:05:21 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9BFB8CA6; Thu, 15 Jan 2015 20:05:21 +0000 (UTC) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7E45C907; Thu, 15 Jan 2015 20:05:21 +0000 (UTC) Received: from aurora.physics.berkeley.edu (aurora.Physics.Berkeley.EDU [128.32.117.67]) (authenticated bits=0) by d.mail.sonic.net (8.14.9/8.14.9) with ESMTP id t0FK5E2d017789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 15 Jan 2015 12:05:14 -0800 Message-ID: <54B81D7A.6080502@freebsd.org> Date: Thu, 15 Jan 2015 12:05:14 -0800 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: John Baldwin , Warner Losh , Justin Hibbits Subject: Re: svn commit: r277163 - head/sys/dev/cardbus References: <201501140541.t0E5fV00070032@svn.freebsd.org> <54B67BC9.70904@FreeBSD.org> <20150114073246.74c159df@zhabar.attlocal.net> <8CB7CB29-FBFF-4850-A226-4FA5B6BF6A87@bsdimp.com> <54B7E8EA.1090509@freebsd.org> <54B80C46.2010409@FreeBSD.org> In-Reply-To: <54B80C46.2010409@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Sonic-CAuth: UmFuZG9tSVbFCVIlO5tU16luEPxvTpCUMK7Y9y8Lhe7GjHSgKfRjQby/OfAAdup1oKCU5LiY6IQMlb2SopopVMvsWZ+6d2sigeyXgJVEWTk= X-Sonic-ID: C;mEmW0fGc5BGum9mh1eMT4g== M;1iXR0fGc5BGum9mh1eMT4g== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 20:05:21 -0000 On 01/15/15 10:51, John Baldwin wrote: > On 1/15/15 11:20 AM, Nathan Whitehorn wrote: >> On 01/14/15 16:07, Warner Losh wrote: >>>> On Jan 14, 2015, at 8:32 AM, Justin Hibbits >>>> wrote: >>>> >>>> On Wed, 14 Jan 2015 09:23:05 -0500 >>>> John Baldwin wrote: >>>> >>>>> On 1/14/15 12:41 AM, Warner Losh wrote: >>>>>> Author: imp >>>>>> Date: Wed Jan 14 05:41:31 2015 >>>>>> New Revision: 277163 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/277163 >>>>>> >>>>>> Log: >>>>>> Add a rather obnoxious warning if you don't have NEW_PCIB defined >>>>>> since it's a total crap shoot if things will work. >>>>> Should we just make it a #error instead? (Some day I hope to have >>>>> NEW_PCIB enabled by default and remove the old code. Will take a >>>>> while to get there for the generic PCI code, but cardbus is probably >>>>> only used on x86 so that would be fine.) >>>>> >>>> Also powerpc, but NEW_PCIB is default there as well. >>> PowerPC doesn’t seem to defined the bus number resources. >>> >>> Warner >>> >> Which ones? >> -Nathan > PCI_RES_BUS. > > https://svnweb.freebsd.org/base?view=revision&revision=261790 > > I misspoke about it being in the nexus. On x86 it is done in the ACPI > Host-PCI bridge drivers (since those have a _SEG method to know which > PCI domain/segment/hose the child bus belongs to). You could > conceivably do it higher up at whatever level understands which PCI > domain a given Host-PCI bridge lives in. > > If you only ever support a single PCI domain, you could just place it in > the nexus with a hardcoded domain arg of 0 to the pci_domain_*() functions. > Most PPC systems have at least two and usually more PCI domains. I'll take a look at adding this. -Nathan