Date: Thu, 3 Jul 1997 05:57:18 -0700 (PDT) From: itojun@itojun.org To: freebsd-gnats-submit@FreeBSD.ORG Subject: kern/4020: vxget() in /sys/dev/vx/if_vx.c needs rework Message-ID: <199707031257.FAA08386@hub.freebsd.org> Resent-Message-ID: <199707031300.GAA08554@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 4020 >Category: kern >Synopsis: vxget() in /sys/dev/vx/if_vx.c needs rework >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 3 06:00:01 PDT 1997 >Last-Modified: >Originator: Jun-ichiro Itoh >Organization: >Release: 2.2.1-RELEASE >Environment: libretto30 >Description: vxget() in if_vx.c almost always store packet into multiple mbufs. It makes upper-layer protocol processing slightly slower. The code looks awful (I'm not attacking the author, sorry) and can be simplified/can be made more readable. it would be better if: packet > MHLEN to be put into single external mbuf otherwise store into single internal mbuf The problem still remains in the latest source in CVS branch. >How-To-Repeat: none >Fix: I'll try it later if nobody does it. >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199707031257.FAA08386>