Date: Tue, 23 Jun 2020 17:52:54 -0600 From: Adam Weinberger <adamw@adamw.org> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r539975 - in head/x11-themes: . slim-freebsd-dark-theme Message-ID: <CAP7rwchi%2BMFaDsnH=y1rjLG-9F36cvAHhsSiJBjptaS1qBGkZQ@mail.gmail.com> In-Reply-To: <e64ab5c0-e339-1b6a-b55f-823a1bff22d3@FreeBSD.org> References: <202006231225.05NCPGsL001130@repo.freebsd.org> <CAP7rwchFe7qqiztufHM5E6U5bpFotz5O6DJB0RMS2couU=Sbdg@mail.gmail.com> <93fdbb58-3e28-3417-cd23-c07e168cd2f2@FreeBSD.org> <CAP7rwciZVtXixHdn3nrOEWY3b%2BBzrVteuPKObyjNWPFcaxDVGw@mail.gmail.com> <e64ab5c0-e339-1b6a-b55f-823a1bff22d3@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 23, 2020 at 5:41 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > On 6/24/20 12:43 AM, Adam Weinberger wrote: > > On Tue, Jun 23, 2020 at 4:40 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > >> On 6/24/20 12:12 AM, Adam Weinberger wrote: > >>> On Tue, Jun 23, 2020 at 6:25 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: > >>>> URL: https://svnweb.freebsd.org/changeset/ports/539975 > >>>> > >>>> Log: > >>>> New port: x11-themes/slim-freebsd-dark-theme > >> [...] > >>> Shouldn't this port have a RUN_DEPENDS on x11/slim? > >> I've checked similar ports and they do not depend on x11/slim. > > Interesting. Should they? You know far more about the use-case here > > than I do so I definitely defer to your judgment, but the description > > makes it sound like x11/xlim is required to make it go. > > It is required, of course. It is a theme after all ;) > > I have a feeling that it would not help the end user to have RUN_DEPENDS > here. In fact, I can imagine that new SLiM users might want to install a > theme first, see if they like it based on the included screenshots, and > then decide to download x11/slim. When it comes to old SLiM users, they > have x11/slim installed anyway. > > Hmm, but the more I think about it, the more I feel it is not how we > manage ports. We should at least have a SLIM option defined and then set > SLIM_RUN_DEPENDS. But then who would really use it? Maybe we should just > set RUN_DEPENDS=slim:x11/slim. > > Eh. > > What do you think, Adam? The WWW has a screenshot, so that's a viable alternative for try-before-you-buy. Personally, I'd go with the hard dep, because the port isn't usable without SLiM, and right now SLiM will show up as a leaf port. And as you mentioned, the hard dep is more consistent with our usual dependency handling. Ability to investigate assets is not a typical use-case for installing without dependencies. That said, you're correct that most users will connect the two and install x11/slim when needed. Personally I'd include the dep, but I certainly won't fault you for opting not to at the end of the day. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwchi%2BMFaDsnH=y1rjLG-9F36cvAHhsSiJBjptaS1qBGkZQ>