From nobody Thu Jul 31 10:07:03 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bt4WD0H7dz63hdC; Thu, 31 Jul 2025 10:07:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bt4WC6dC3z3x8H; Thu, 31 Jul 2025 10:07:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753956423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YE3dkPe5wDCg1uvm2uJsUhQsBBjqxQCIYSfNooLzUd8=; b=tF3o1W/smXJkeYScCeCX/TvibEw8iShu9Qu+TCYORXJOpLuodnGzB8Y68SgxQ7lQx8CorT DXxBC/TpMc6uKHjcN46zWt019601ZDdPd80uQY0uKElrBSZvMy9vxVUAkI1aBodnd3XsLD hrln6lUcJJvfJgpJpswncS9Z7xpJXZTlrYMwb0tqwJ5BRoWKma4DCIdPpXxfxbW7DJfO4F G1IlNa/PDvAI8jsGGstDbpsYHWWk5C4j6oNrnh6caSyRpe12z+lTPp5BFVKWK4cqBebo3M 4eqq8miZarLMCl2USdbwDtVoNFkZR05y/f2EmbupX+pyXSYBqG4lm+EV4CJNnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753956423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YE3dkPe5wDCg1uvm2uJsUhQsBBjqxQCIYSfNooLzUd8=; b=xOCyMhnlJV2TaPy0S+Ikkd/tGJg4xMpq8F5ekfQOiSfzFb1GE8J+ixkMQa1bi+pfXGW/Bk o7dGf6GEDf2CzTfuRUwGd9JuamAAeHCPgdFlQOjg/IfrEi2CXQh7nEbnZ3nkDAkk9R7VvX 06OHhJmk9PH6K/iJv7b60sgq+UDxKv7cjWOhBfYnrBKLtcuqC6UuPsR4i17EYQpu2tBOoj osk+ioSlZec7b1dOkuONZIcVuqDDd3YaL8holqIPJnnnVjS0iIJBnDhaj4I/UGGsBtxaCM pdmlgKWHS2wDi9HKGEhl77rgaC646v5rq29W2O80RSCeO6F1zQkxhlX+tQBJcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753956423; a=rsa-sha256; cv=none; b=C8fKjIx7HpMg5ZemOGyT5a852N7qmSzrBR5aIa8CE6g4XYrcEDAzrVMh1V+WZkBF0MKqWk jEhj+AKSnbJy65vUXytIF9Q14nxFbeFeKfH312zAoWFYTYbj4EHr3T4I0Hsu+DWoiu7u2W m5aZu0hR3x5I/Av0Bk6a2nTQ9GTU+GCY2/fRH8GZ+2WtGzChWusZbePZLyyEChNjnLdsJo THKi5d20fwyn6f/s2kmwYcp3sVOfJh0rL5UimD9UWsqM9AS8YN4jwYBSo23+DtkqK920f4 fgLWgaxNX5rj6awgqhihDuM2ZIpqftrKtshAumMe1kQH1UBHXzKRPSHO9eDkcQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bt4WC5nqqzxwb; Thu, 31 Jul 2025 10:07:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56VA73VG067881; Thu, 31 Jul 2025 10:07:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56VA73qn067878; Thu, 31 Jul 2025 10:07:03 GMT (envelope-from git) Date: Thu, 31 Jul 2025 10:07:03 GMT Message-Id: <202507311007.56VA73qn067878@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: a8d90e32133b - main - netlink: Fully clear parser state between messages List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a8d90e32133b77a49c2551f22e59f72d65293b64 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=a8d90e32133b77a49c2551f22e59f72d65293b64 commit a8d90e32133b77a49c2551f22e59f72d65293b64 Author: Dag-Erling Smørgrav AuthorDate: 2025-07-31 10:06:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-07-31 10:06:47 +0000 netlink: Fully clear parser state between messages Failing to reset the cookie between messages can lead to an attempt to interpret a zeroed buffer as a struct nlattr, causing a length calculation to underflow, resulting in a memcpy() call where the length exceeds the actual size of the buffer. MFC after: 1 week PR: 283797 Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D51634 --- sys/netlink/netlink_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netlink/netlink_io.c b/sys/netlink/netlink_io.c index ce323910af3f..e7908d6f3a44 100644 --- a/sys/netlink/netlink_io.c +++ b/sys/netlink/netlink_io.c @@ -308,6 +308,7 @@ static void npt_clear(struct nl_pstate *npt) { lb_clear(&npt->lb); + npt->cookie = NULL; npt->error = 0; npt->err_msg = NULL; npt->err_off = 0;