From owner-freebsd-arch Mon Jan 22 20: 7:23 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mass.dis.org (mass.dis.org [216.240.45.41]) by hub.freebsd.org (Postfix) with ESMTP id E9B9D37B400; Mon, 22 Jan 2001 20:07:06 -0800 (PST) Received: from mass.dis.org (localhost [127.0.0.1]) by mass.dis.org (8.11.1/8.11.1) with ESMTP id f0N4MTG01012; Mon, 22 Jan 2001 20:22:29 -0800 (PST) (envelope-from msmith@mass.dis.org) Message-Id: <200101230422.f0N4MTG01012@mass.dis.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: "Brian F. Feldman" Cc: arch@FreeBSD.org, alfred@FreeBSD.org Subject: Re: struct ucred is evil and must be contained In-reply-to: Your message of "Mon, 22 Jan 2001 22:58:56 EST." <200101230358.f0N3wvW01298@green.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 22 Jan 2001 20:22:29 -0800 From: Mike Smith Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > Okay, maybe the subject is a bit sensationalistic, but the fact remains that > ucred has grown into a monster, in the same manner of struct proc, that > needs to be carefully contained. In this vain, I've created a struct xucred > and replaced uses of ucred outside of the kernel with it where possible. > > This will also happen to fix the bug that if you screw up your interfaces > (change the size of ucred, for example), mountd and nfsd will not panic the > kernel because of it. This is a very good thing! Comments? #ifdef _KERNEL struct xucred { #else struct ucred { #endif The struct must be known as "ucred" in userspace to maintain compatibility with the old interfaces. -- ... every activity meets with opposition, everyone who acts has his rivals and unfortunately opponents also. But not because people want to be opponents, rather because the tasks and relationships force people to take different points of view. [Dr. Fritz Todt] V I C T O R Y N O T V E N G E A N C E To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message