From nobody Wed Oct 20 12:35:16 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A545217C55D2; Wed, 20 Oct 2021 12:35:19 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HZ97C4LQNz3wSv; Wed, 20 Oct 2021 12:35:19 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 5DEC89597; Wed, 20 Oct 2021 12:35:19 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id E86A4B34E6; Wed, 20 Oct 2021 14:35:16 +0200 (CEST) Date: Wed, 20 Oct 2021 14:35:16 +0200 From: Baptiste Daroussin To: Eric Turgeon Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 674d093cd093 - main - x11/mate-panel: Revert "x11/mate-panel: Revert to 1.24.2 and bump PORTEPOCH" Message-ID: <20211020123516.x35p5hrbk4rofd5d@aniel.nours.eu> References: <202110192337.19JNbWYG049096@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202110192337.19JNbWYG049096@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Oct 19, 2021 at 11:37:32PM +0000, Eric Turgeon wrote: > The branch main has been updated by ericbsd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=674d093cd09349d36e8dec9c0dcdf05daf0fc988 > > commit 674d093cd09349d36e8dec9c0dcdf05daf0fc988 > Author: Eric Turgeon > AuthorDate: 2021-10-19 23:34:33 +0000 > Commit: Eric Turgeon > CommitDate: 2021-10-19 23:37:24 +0000 > > x11/mate-panel: Revert "x11/mate-panel: Revert to 1.24.2 and bump PORTEPOCH" > > This reverts commit 0d45d70a5fdf13af63c2363ae7c57a1def43415f. > > It should have never been reverted at the first place. > > PR: 259058 > Reported by: John Hein I brought back portepoch it should never ever be removed. concerning the commit log, form completeness and as discuss on IRC. The revert from nc@ had a reason, there was a breakage and he considered he could not have time to fix so he reverted while this is debattable if it was done too early or not, this remain a valid reason. What was wrong was that he didn't mention at all the reasons for the revert in the commit log! Now this commit log would deserve also a bit more verbosity, you can revert back, because it seems the underlying issue was on mate-themes and the upgrade of mate-themes fixed the issue. Best regards, Bapt