From owner-freebsd-hackers  Mon Mar 13 16:04:34 1995
Return-Path: hackers-owner
Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id QAA02251 for hackers-outgoing; Mon, 13 Mar 1995 16:04:34 -0800
Received: from trout.sri.MT.net (trout.sri.MT.net [204.182.243.12]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id QAA02245 for <freebsd-hackers@freefall.cdrom.com>; Mon, 13 Mar 1995 16:04:31 -0800
Received: (from nate@localhost) by trout.sri.MT.net (8.6.9/8.6.9) id RAA03977; Mon, 13 Mar 1995 17:08:21 -0700
Date: Mon, 13 Mar 1995 17:08:21 -0700
From: Nate Williams <nate@trout.sri.MT.net>
Message-Id: <199503140008.RAA03977@trout.sri.MT.net>
In-Reply-To: Steven G Kargl  <kargl@troutmask.apl.washington.edu>
       "install compressed binary patch" (Mar 13,  3:46pm)
X-Mailer: Mail User's Shell (7.2.5 10/14/92)
To: Steven G Kargl  <kargl@troutmask.apl.washington.edu>,
        freebsd-hackers@freefall.cdrom.com (FreeBSD)
Subject: Re: install compressed binary patch
Sender: hackers-owner@FreeBSD.org
Precedence: bulk

> I have added a `-z' option to install.

Cool.

But..

> + 	/*
> + 	 * Compression must have been successful, if we get here.
> + 	 * So, build a filename for the gzipped file
> + 	 */
> + 	if (strlen(to_name) < MAXPATHLEN - 3)
> + 		strcpy(gz_name, to_name);
> + 	strcat(gz_name, ".gz");

What happens if strlen(to_name) >= MAXPATHLEN -3?

Also, wouldn't it be better to copy the file into a temporary directory,
gzip it, and then install the gzipped executable rather than the symlink
solution?  We don't need multiple copies of the file lying around IMHO.


Nate