From owner-svn-src-all@freebsd.org Wed May 25 13:23:50 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB67DB498B9; Wed, 25 May 2016 13:23:50 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 84AB318FC; Wed, 25 May 2016 13:23:49 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (unknown [62.141.129.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 2CEDE1FE024; Wed, 25 May 2016 15:23:47 +0200 (CEST) Subject: Re: svn commit: r299393 - in head: . share/mk To: John Baldwin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201605102232.u4AMWNvp000287@repo.freebsd.org> From: Hans Petter Selasky Message-ID: <08cfa0ac-ad92-c8f9-2141-e72088b17d41@selasky.org> Date: Wed, 25 May 2016 15:27:07 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <201605102232.u4AMWNvp000287@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 13:23:50 -0000 On 05/11/16 00:32, John Baldwin wrote: > Author: jhb > Date: Tue May 10 22:32:23 2016 > New Revision: 299393 > URL: https://svnweb.freebsd.org/changeset/base/299393 > > Log: > Change the default installation directory for modules to /boot/modules. > > Kernel installs always override KMODDIR when installing modules, so > this default setting is only used for standalone module builds. Many > out-of-tree modules manually override KMODDIR already to avoid placing > modules in /boot/kernel. This now makes that behavior the default. > > Discussed on: arch@ > Reviewed by: imp > Relnotes: yes > > Modified: > head/UPDATING > head/share/mk/bsd.own.mk > > Modified: head/UPDATING > ============================================================================== > --- head/UPDATING Tue May 10 22:28:06 2016 (r299392) > +++ head/UPDATING Tue May 10 22:32:23 2016 (r299393) > @@ -31,6 +31,14 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11 > disable the most expensive debugging functionality run > "ln -s 'abort:false,junk:false' /etc/malloc.conf".) > > +20160510: > + Kernel modules compiled outside of a kernel build now default to > + installing to /boot/modules instead of /boot/kernel. Many kernel > + modules built this way (such as those in ports) already overrode > + KMODDIR explicitly to install into /boot/modules. However, > + manually building and installing a module from /sys/modules will > + now install to /boot/modules instead of /boot/kernel. > + > 20160414: > The CAM I/O scheduler has been committed to the kernel. There should be > no user visible impact. This does enable NCQ Trim on ada SSDs. While the > > Modified: head/share/mk/bsd.own.mk > ============================================================================== > --- head/share/mk/bsd.own.mk Tue May 10 22:28:06 2016 (r299392) > +++ head/share/mk/bsd.own.mk Tue May 10 22:32:23 2016 (r299393) > @@ -165,11 +165,7 @@ BINGRP?= wheel > BINMODE?= 555 > NOBINMODE?= 444 > > -.if defined(MODULES_WITH_WORLD) > KMODDIR?= /boot/modules > -.else > -KMODDIR?= /boot/kernel > -.endif > KMODOWN?= ${BINOWN} > KMODGRP?= ${BINGRP} > KMODMODE?= ${BINMODE} > Just a small nit: There is a comment in bsd.own.mk which needs updating too: > # > # KMODDIR Base path for loadable kernel modules > # (see kld(4)). [/boot/kernel] --HPS